Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] SolutionProjectModel Full Paths #47422

Merged
merged 1 commit into from
Mar 11, 2025
Merged

[REF] SolutionProjectModel Full Paths #47422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Cli/dotnet/ReleasePropertyProjectLocator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public IEnumerable<string> GetCustomDefaultConfigurationValueIfSpecified()
Parallel.ForEach(sln.SolutionProjects.AsEnumerable(), (project, state) =>
{
#pragma warning disable CS8604 // Possible null reference argument.
string projectFullPath = Path.Combine(Path.GetDirectoryName(slnFullPath), project.FilePath);
string projectFullPath = Path.GetFullPath(project.FilePath, Path.GetDirectoryName(slnFullPath));
#pragma warning restore CS8604 // Possible null reference argument.
if (IsUnanalyzableProjectInSolution(project, projectFullPath))
return;
Expand Down Expand Up @@ -220,7 +220,7 @@ public IEnumerable<string> GetCustomDefaultConfigurationValueIfSpecified()
foreach (var project in sln.SolutionProjects.AsEnumerable())
{
#pragma warning disable CS8604 // Possible null reference argument.
string projectFullPath = Path.Combine(Path.GetDirectoryName(slnPath), project.FilePath);
string projectFullPath = Path.GetFullPath(project.FilePath, Path.GetDirectoryName(slnPath));
#pragma warning restore CS8604 // Possible null reference argument.
if (IsUnanalyzableProjectInSolution(project, projectFullPath))
continue;
Expand Down
Loading