Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit specifying to use workload versions in global.json #47421

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Mar 10, 2025

Uses useWorkloadVersions next to where you'd put a specific workload version

This probably deserves a little more testing than I've given it so far

Uses useWorkloadVersions next to where you'd put a specific workload version
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Workloads untriaged Request triage from a team member labels Mar 10, 2025
@baronfel
Copy link
Member

nit: try to make this align with the existing --update-mode settings we have. Maybe have the setting be "workloads-update-mode": "manifests" | "workload-sets" (whatever aligns with our existing CLI naming.

@Forgind
Copy link
Member Author

Forgind commented Mar 10, 2025

nit: try to make this align with the existing --update-mode settings we have. Maybe have the setting be "workloads-update-mode": "manifests" | "workload-sets" (whatever aligns with our existing CLI naming.

That seems reasonable. I'll probably just handle that in the parsing bit so I don't have to change anything else, but no one else will be able to tell 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Workloads untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants