Create logger directory if it doesn't exist in dotnet test #47411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-dotnet test
untriaged
There was a problem hiding this comment.
PR Overview
This PR ensures that the logger directory is created automatically before writing test logs.
- Checks if the directory extracted from _traceFilePath exists and creates it if missing.
- Enhances the robustness of the dotnet test logging functionality.
Reviewed Changes
| File | Description |
|---|---|
| src/Cli/dotnet/commands/dotnet-test/Logger.cs | Added logic to create the directory for the logger if it does not exist |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Youssef1313
reviewed
Mar 11, 2025
Youssef1313
reviewed
Mar 11, 2025
Youssef1313
approved these changes
Mar 11, 2025
Youssef1313
reviewed
Mar 11, 2025
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Youssef1313
reviewed
Mar 11, 2025
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
Outdated
Show resolved
Hide resolved
Youssef1313
approved these changes
Mar 11, 2025
…fferentOptions.cs Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
mariam-abdulla
deleted the
dev/mabdullah/fix-bug-logger-env-var-in-dotnet-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #45927
Fixes microsoft/testfx#5205