Generate the sdk msi bundles inside the VMR on windows BuildPass=2 verticals #47397
+523
−479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rticals Fixes dotnet/source-build#4777 The msi bundle depends on artifacts from other windows verticals. Therefore, it needs to be generated in a BuildPass=2 vertical in the VMR. Update the existing BuildPass2 verticals and add the win-arm64 one. Update the logic to set a Boolean property that decides whether only the sdk bundle should be generated in redist-installer.proj. Update existing code so that GenerateMsis.targets doesn't not depend on other targets files aside form the newly introduce RestoreLayout.targets.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
…WindowsBuildPass2
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR enables MSI bundle generation for the SDK in the VMR on Windows BuildPass=2 verticals by updating existing build configurations and adding support for the win-arm64 vertical.
- Updated the reuseBuildArtifactsFrom section to include Windows_arm64.
- Added a new stage block for a Windows build targeting arm64.
Comments suppressed due to low confidence (1)
eng/pipelines/templates/stages/vmr-build.yml:897
- In the stage with targetArchitecture: x86, the reuseBuildArtifactsFrom list includes 'Windows_arm64'. Please verify if referencing an arm64 artifact for an x86 target is intentional.
- Windows_arm64
….com/ViktorHofer/sdk into GenerateSdkBundleInWindowsBuildPass2
akoeplinger
reviewed
Mar 11, 2025
akoeplinger
approved these changes
Mar 11, 2025
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4777
The msi bundle depends on artifacts from other windows verticals. Therefore, it needs to be generated in a BuildPass=2 vertical in the VMR.
This approach (introducing a new boolean) is the fastest one to unblock the missing sdk msi bundle generation in the VMR. It makes the existing code harder to follow. After this is merged and we have time, it would be ideal to componentize some parts into separate projects.