Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0.3xx] Update dependencies from dotnet/msbuild #47385

Merged
merged 5 commits into from
Mar 9, 2025
Merged

[release/9.0.3xx] Update dependencies from dotnet/msbuild #47385

merged 5 commits into from
Mar 9, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 8, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/msbuild

@dotnet-maestro
Update dependencies from https://github.com/dotnet/msbuild build 2025…
da25830 
…0307.7

Microsoft.SourceBuild.Intermediate.msbuild , Microsoft.Build , Microsoft.Build.Localization
 From Version 17.14.0-preview-25155-03 -> To Version 17.14.0-preview-25157-07
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Mar 8, 2025
@kasperk81 kasperk81 mentioned this pull request Mar 8, 2025
Merged
@akoeplinger akoeplinger enabled auto-merge (squash) March 8, 2025 14:41
This was referenced Mar 8, 2025
Open
Open
Open
@akoeplinger
Copy link
Member

@edvilme @kasperk81 I reenabled the tests and the dotnet solution add works now but it looks like the sln is still not correct:

Executing 'dotnet solution App.sln add foo\bar':
》Project `foo\bar\bar.csproj` added to the solution.
Command 'dotnet solution App.sln add foo\bar' exited with exit code 0.
Executing 'dotnet solution App.sln add foo':
》Project `foo\foo.csproj` added to the solution.
Command 'dotnet solution App.sln add foo' exited with exit code 0.
Executing 'dotnet build App.sln':
》C:\h\w\B220096E\t\dotnetSdkTests\vzoxd5z0.fqo\WhenNestedPro---BDFD3014\App.sln : Solution file error MSB5004: The solution file has two projects named "foo".
》
》Build FAILED.

@akoeplinger
Copy link
Member

Ah we probably need to opt-in to the new parser via MSBUILD_PARSE_SLN_WITH_SOLUTIONPERSISTENCE right?

@akoeplinger akoeplinger requested a review from a team as a code owner March 9, 2025 16:27
@build-analysis build-analysis bot mentioned this pull request Mar 9, 2025
Open
@akoeplinger akoeplinger merged commit 8b956dc into release/9.0.3xx Mar 9, 2025
33 of 34 checks passed
@akoeplinger akoeplinger deleted the darc-release/9.0.3xx-014bea59-c81d-4e13-94e7-02044278dfdd branch March 9, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akoeplinger