[main] Update dependencies from dotnet/source-build-externals

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-externals

• Subscription: 6d39c54a-1ca8-4c07-6386-08d9fbbd2f07
• Build: 20250310.1
• Date Produced: March 10, 2025 4:13:07 PM UTC
• Commit: 96dceea0417e9ff1b47664c2d2998b9abf541f0c
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.source-build-externals: from 10.0.615301 to 10.0.616001

[edvilme]

Hello @dotnet/source-build is there a reason source build is failing?

[akoeplinger]

The reason it's failing is because of this:

[xUnit.net 00:00:01.16]     Microsoft.DotNet.SourceBuild.Tests.SymbolsTests.VerifySdkSymbols [FAIL]
[xUnit.net 00:00:01.17]       Assert.True() Failure
[xUnit.net 00:00:01.17]       Expected: True
[xUnit.net 00:00:01.17]       Actual:   False
[xUnit.net 00:00:01.17]       Stack Trace:
[xUnit.net 00:00:01.17]         /_/test/Microsoft.DotNet.SourceBuild.Tests/SymbolsTests.cs(57,0): at Microsoft.DotNet.SourceBuild.Tests.SymbolsTests.VerifySdkSymbols()
[xUnit.net 00:00:01.17]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:01.17]            at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
[xUnit.net 00:00:01.17]       Output:
[xUnit.net 00:00:01.17]         Executing: tar xzf /__w/1/vmr/artifacts/assets/Release/dotnet-symbols-sdk-10.0.100-preview.3.25160.1-centos.9-x64.tar.gz -C /__w/1/vmr/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/SymbolsTests/symbols
[xUnit.net 00:00:01.17]         Did not find PDBs for the following SDK files:
[xUnit.net 00:00:01.17]         /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-preview.3.25160.1/DotnetTools/dotnet-format/Microsoft.VisualStudio.SolutionPersistence.dll
[xUnit.net 00:00:01.17]         /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-preview.3.25160.1/DotnetTools/dotnet-watch/10.0.100-preview.3.25160.1/tools/net10.0/any/Microsoft.VisualStudio.SolutionPersistence.dll
[xUnit.net 00:00:01.17]         /__w/1/vmr/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-preview.3.25160.1/Microsoft.VisualStudio.SolutionPersistence.dll

but I'm not sure why, the files I've checked do include the Microsoft.VisualStudio.SolutionPersistence.pdb but for some reason it doesn't end up in dotnet-symbols-sdk .tar.gz

[akoeplinger]

I think what happens is that it's still using the old version of the package from the nuget feed, but using the .pdb from the new version built in source-build-externals. I've cherry-picked the version changes into #47377, let's see if that fixes it.

[ViktorHofer]

@dotnet/source-build please review the Alex's latest commit which adds a new RepositoryReference from msbuild -> SBE.

[akoeplinger]

hm it didn't help as the test still fails, we probably still need to go with the combined #47377

actually, I think cherry-picking the version bump of the package itself is necessary too, let me try that

[akoeplinger]

Ok it appears that worked :)

[akoeplinger]

msbuild started consuming a package from source-build-externals with dotnet/msbuild@adb4394 so adding the RepositoryReference seems correct to me but @dotnet/source-build please confirm.

[edvilme]

Hello @akoeplinger @dotnet/source-build sdk-source-build keeps on failing and lists MSBuild as the reason.
Would merging #47377 first help with this?

cc @dotnet/kitten

[akoeplinger]

Yes I think this will need #47377 which needs dotnet/msbuild#11561 which needs dotnet/source-build-externals#458 😆

[edvilme]

Yes I think this will need #47377 which needs dotnet/msbuild#11561 which needs dotnet/source-build-externals#458 😆

Great thanks, will keep an aye :)

[ViktorHofer]

Still blocked on #47377. Paaaaatieeeence ;)

[edvilme]

Still blocked on #47377. Paaaaatieeeence ;)

Ohh sorry, updated the wrong PR hehe