Clean up extensions for dotnet CLI & Utils #47373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…older. Moved other Extensions classes into the Extensions folder.
…ted Extensions namespace for all Extension classes.
MiYanni
commented
Mar 8, 2025
| var lastMatchingItemGroup = FindExistingUniformItemGroupWithCondition(root, projectItemElementType, framework); | ||
| var lastMatchingItemGroup = root.FindExistingUniformItemGroupWithCondition(projectItemElementType, framework); |
There was a problem hiding this comment.
VS IDE did this automatically.
There was a problem hiding this comment.
PR Overview
This PR cleans up and normalizes the Extensions classes for the dotnet CLI and related projects by moving them into a dedicated Extensions folder and updating the relevant namespaces.
- Moved Extensions classes to an Extensions folder in the dotnet CLI project.
- Normalized namespaces across the Extensions classes and updated using directives in consuming files.
- Renamed CommonOptionsExtension to CommonOptionsExtensions to align with naming conventions.
Reviewed Changes
| File | Description |
|---|---|
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/CollectionsExtensions.cs | Updated namespace to Microsoft.DotNet.Cli.Utils.Extensions. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/LockFileExtensions.cs | Changed namespace and updated class access modifier to internal. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ExceptionExtensions.cs | Updated namespace to Microsoft.DotNet.Cli.Utils.Extensions. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessStartInfoExtensions.cs | Updated namespace to Microsoft.DotNet.Cli.Utils.Extensions. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/AnsiExtensions.cs | Updated namespace to Microsoft.DotNet.Cli.Utils.Extensions. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/MSBuildProjectExtensions.cs | Updated namespace and modified an extension method call for clarity. |
| src/Cli/Microsoft.DotNet.Cli.Utils/ForwardingAppImplementation.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/LockFileFormatExtensions.cs | Updated namespace to Microsoft.DotNet.Cli.Utils.Extensions. |
| src/Cli/Microsoft.DotNet.Cli.Utils/GracefulException.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.DotNet.Cli.Utils/EnvironmentProvider.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Command.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.DotNet.Cli.Utils/Extensions/ProcessExtensions.cs | Updated namespace to Microsoft.DotNet.Cli.Utils.Extensions. |
| src/Cli/Microsoft.DotNet.Configurer/CliFolderPathCalculator.cs | Updated using directive to the new Extensions namespace. |
| src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs | Added using directive for the updated Extensions namespace. |
| src/BuiltInTools/dotnet-watch/CommandLineOptions.cs | Updated using directive to reference Microsoft.DotNet.Cli.Extensions. |
| src/Cli/Microsoft.TemplateEngine.Cli/PostActionProcessors/InstructionDisplayPostActionProcessor.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.TemplateEngine.Cli/Commands/create/InstantiateCommand.NoMatchHandling.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.TemplateEngine.Cli/Commands/create/InstantiateCommand.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.TemplateEngine.Cli/PostActionDispatcher.cs | Added using directive for the updated Extensions namespace. |
| src/Cli/Microsoft.TemplateEngine.Cli/Commands/BaseCommand.cs | Added using directive for the updated Extensions namespace. |
Copilot reviewed 163 out of 163 changed files in this pull request and generated no comments.
MiYanni
commented
Mar 8, 2025
| return option.SetForwardingFunction((string o) => | ||
| return option.SetForwardingFunction((o) => |
There was a problem hiding this comment.
Also automatic by VS IDE.
Forgind
approved these changes
Mar 8, 2025
# Conflicts: # src/Cli/dotnet/Extensions/OptionForwardingExtensions.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple PR. Does exactly these things for the
dotnetandMicrosoft.DotNet.Cli.Utilsprojects:sto match the naming style convention.