Fixup sourcelink information #47363
Merged
Fixup sourcelink information #47363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most repos are setting the RepositoryUrl directly in their directory.build.props. This leads to incorrect sourcelink information. The SHA built does not exist in the isolated repo.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
I think I'll need an additional patch for runtime and maybe aspnetcore, to map this in to their inner builds. |
jkoritzinsky
approved these changes
Mar 7, 2025
ViktorHofer
approved these changes
Mar 8, 2025
Forgind
approved these changes
Mar 9, 2025
|
I'm going to merge this now, then @pavel-purma's sourcelink testing in the staging pipeline can identify issues. May also integrate that into the build comparison testing. |
ViktorHofer
added a commit
that referenced
this pull request
Mar 10, 2025
This reverts commit 8727359.
baronfel
pushed a commit
to baronfel/sdk
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most repos are setting the RepositoryUrl directly in their directory.build.props. This leads to incorrect sourcelink information. The SHA built does not exist in the isolated repo.