Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/templating #47319

Merged
merged 5 commits into from
Mar 7, 2025
Merged

[main] Update dependencies from dotnet/templating #47319

merged 5 commits into from
Mar 7, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 6, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/templating

@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
e6069f1 
…0250306.2

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Authoring.TemplateVerifier , Microsoft.TemplateEngine.Edge , Microsoft.TemplateEngine.Mocks , Microsoft.TemplateEngine.Orchestrator.RunnableProjects , Microsoft.TemplateEngine.TestHelper , Microsoft.TemplateEngine.Utils , Microsoft.TemplateSearch.Common , Microsoft.TemplateSearch.TemplateDiscovery
 From Version 10.0.100-preview.3.25155.2 -> To Version 10.0.100-preview.3.25156.2
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Mar 6, 2025
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

dotnet-maestro bot commented Mar 6, 2025

Notification for subscribed users from https://github.com/dotnet/templating:

@dotnet/templating-engine-maintainers

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/templating) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

edvilme and others added 2 commits March 6, 2025 16:31
@edvilme
Merge branch 'main' into darc-main-495f03d6-250e-4467-a43a-624b5b5d9d24
59043d4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/templating build 2…
ca267b5 
…0250306.16

Microsoft.SourceBuild.Intermediate.templating , Microsoft.TemplateEngine.Abstractions , Microsoft.TemplateEngine.Authoring.TemplateVerifier , Microsoft.TemplateEngine.Edge , Microsoft.TemplateEngine.Mocks , Microsoft.TemplateEngine.Orchestrator.RunnableProjects , Microsoft.TemplateEngine.TestHelper , Microsoft.TemplateEngine.Utils , Microsoft.TemplateSearch.Common , Microsoft.TemplateSearch.TemplateDiscovery
 From Version 10.0.100-preview.3.25155.2 -> To Version 10.0.100-preview.3.25156.16
@v-wuzhai
Copy link
Member

v-wuzhai commented Mar 7, 2025

@dotnet/product-construction Could you take a look at the VMR failures here?

@akoeplinger
Copy link
Member

fatal: cannot create directory at 'test/Microsoft.TemplateEngine.Orchestrator.RunnableProjects.UnitTests/Approvals/TestSelectionForMultiChoicesWhenThereAreMultiplePartialMatchesAndOnePreciseMatch._.verified/TestAssets.TemplateWithMultipleChoicesAndPartialMatches': Filename too long

as far as I know we should have long paths enabled already. @premun is that something specific to the patching process maybe?

@premun
Copy link
Member

premun commented Mar 7, 2025

Seems like we don't have it on for Windows VMs? This seems to blow up during a regular git checkout command.

@akoeplinger
Copy link
Member

interesting. according to helix.dot.net the windows.vs2022preview.amd64.open build pool does have the windows-enable-long-paths artifact. But I guess we might not have the git side enabled with git config --system core.longpaths true ?

@akoeplinger
Copy link
Member

The AzDO git clone mentions git config core.longpaths true in the log but I'm not sure if that setting also applies to the temporary clone that darc makes.

@premun
Copy link
Member

premun commented Mar 7, 2025

My understanding was that new clones inherit the global settings but I will check.
Is the cmd/PowerShell elevated during AzDO builds? I remember that the system setting required that.

@premun premun requested review from a team as code owners March 7, 2025 12:26
@premun
Copy link
Member

premun commented Mar 7, 2025

@akoeplinger I found out that our custom clone does not set the setting for the just cloned repo. I will add it. Meanwhile I pushed a change here too

premun added a commit to premun/arcade-services that referenced this pull request Mar 7, 2025
@premun
Set core.longpaths to true for newly cloned repos
d1f642b 
dotnet/sdk#47319
premun added a commit to premun/arcade-services that referenced this pull request Mar 7, 2025
@premun
Set core.longpaths to true for newly cloned repos
edf9f0b 
dotnet/sdk#47319
@premun premun mentioned this pull request Mar 7, 2025
Merged
premun added a commit to dotnet/arcade-services that referenced this pull request Mar 7, 2025
@premun
Set core.longpaths to true for newly cloned repos and in PCS (#4538)
0237e4d 
dotnet/sdk#47319
@dotnet-maestro dotnet-maestro bot merged commit 7fdce4e into main Mar 7, 2025
43 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-495f03d6-250e-4467-a43a-624b5b5d9d24 branch March 7, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @akoeplinger @premun @edvilme