Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builds table in VMR and SDK #47312

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 6, 2025

  • Checksums got renamed from .sha to .sha512
  • Add the missing win-arm64 checksum entry
  • Remove win-arm links from VMR builds-table.md

- Checksums got renamed from .sha to .sha512
- Add the missing win-arm64 checksum entry
@Copilot Copilot bot review requested due to automatic review settings March 6, 2025 16:19
@ViktorHofer ViktorHofer requested review from a team as code owners March 6, 2025 16:19
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the builds tables for both the VMR and SDK documentation by renaming checksum references from .sha to .sha512 and adding the missing win-arm64 checksum entry.

  • Renamed all checksum links from .sha to .sha512.
  • Added a win-arm64 checksum entry for both installer and zip assets in the builds tables.

Reviewed Changes

File Description
src/SourceBuild/content/docs/builds-table.md Updated checksum links and added the missing win-arm64 zip checksum.
documentation/package-table.md Updated checksum links to use .sha512 and aligned the win-arm64 row.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comment on lines 171 to +179
[rhel-6-badge-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/rhel.6_x64_Release_version_badge.svg?no-cache
[rhel-6-version-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/productCommit-rhel.6-x64.txt
[rhel-6-targz-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/dotnet-sdk-rhel.6-x64.tar.gz
[rhel-6-targz-checksum-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/dotnet-sdk-rhel.6-x64.tar.gz.sha
[rhel-6-targz-checksum-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/dotnet-sdk-rhel.6-x64.tar.gz.sha512

[rhel-6-badge-9.0.3XX]: https://aka.ms/dotnet/9.0.3xx/daily/rhel.6_x64_Release_version_badge.svg?no-cache
[rhel-6-version-9.0.3XX]: https://aka.ms/dotnet/9.0.3xx/daily/productCommit-rhel.6-x64.txt
[rhel-6-targz-9.0.3XX]: https://aka.ms/dotnet/9.0.3xx/daily/dotnet-sdk-rhel.6-x64.tar.gz
[rhel-6-targz-checksum-9.0.3XX]: https://aka.ms/dotnet/9.0.3xx/daily/dotnet-sdk-rhel.6-x64.tar.gz.sha
[rhel-6-targz-checksum-9.0.3XX]: https://aka.ms/dotnet/9.0.3xx/daily/dotnet-sdk-rhel.6-x64.tar.gz.sha512
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have these files? If so, we should really rename them to their more applicable base targets (as we don't support RHEL6 any more and haven't for years)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep this scoped to the PR's intent. This table will be replaced by VMR's table eventually.

Comment on lines 226 to +234
[win-arm-badge-main]: https://aka.ms/dotnet/10.0.1xx/daily/win_arm_Release_version_badge.svg?no-cache
[win-arm-version-main]: https://aka.ms/dotnet/10.0.1xx/daily/productCommit-win-arm.txt
[win-arm-zip-main]: https://aka.ms/dotnet/10.0.1xx/daily/dotnet-sdk-win-arm.zip
[win-arm-zip-checksum-main]: https://aka.ms/dotnet/10.0.1xx/daily/dotnet-sdk-win-arm.zip.sha
[win-arm-zip-checksum-main]: https://aka.ms/dotnet/10.0.1xx/daily/dotnet-sdk-win-arm.zip.sha512

[win-arm-badge-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/win_arm_Release_version_badge.svg?no-cache
[win-arm-version-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/productCommit-win-arm.txt
[win-arm-zip-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/dotnet-sdk-win-arm.zip
[win-arm-zip-checksum-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/dotnet-sdk-win-arm.zip.sha
[win-arm-zip-checksum-10.0.1XX-preview2]: https://aka.ms/dotnet/10.0.1xx-preview2/daily/dotnet-sdk-win-arm.zip.sha512
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here for win-arm in .NET 10 (also .NET 9 probably)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above. The VMR's table doesn't have win-arm anymore.

@ViktorHofer
Copy link
Member Author

Markdown only change. Force merge.

@ViktorHofer ViktorHofer merged commit d833ffb into main Mar 6, 2025
25 of 40 checks passed
@ViktorHofer ViktorHofer deleted the UpdateBuildsTableInVMRAndSDK branch March 6, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants