Simplify reused artifact download for VMR builds #47268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of downloading and then copying all of the assets from previous builds, just directly download them to the correct folder.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR simplifies the artifact download process for VMR builds by using the DownloadPipelineArtifact task directly instead of downloading and then copying assets.
- Removed separate download and copy steps
- Consolidated operations into a single DownloadPipelineArtifact task
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/templates/jobs/vmr-build.yml | Replaced download and copy steps with the DownloadPipelineArtifact task to streamline artifact handling |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
|
/azp run sdk-unified-build-full |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run sdk-unified-build-full |
mmitche
approved these changes
Mar 5, 2025
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
reviewed
Mar 5, 2025
|
I think the download does overwrite, but I can't find documentation about it either way. We can wait on merging this until I get rid of all duplicates from the different verticals (at which point overwriting doesn't matter) if that's preferred. |
|
If the BuildPass2 verticals all pass with this change I'm fine with merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading and then copying all of the assets from previous builds, just directly download them to the correct folder.