Go back further to buildartifacts #47267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR titled "Go back further to buildartifacts" updates the artifact publishing configuration in the VM build stage.
- Changes the output key from "pipelineArtifact" to "buildArtifacts".
- Updates the keys for publishing artifacts including renaming "path" to "PathtoPublish" and modifying the artifact name.
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/templates/stages/vmr-build.yml | Modified artifact publishing configuration to use "buildArtifacts" and update related parameter names. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
eng/pipelines/templates/stages/vmr-build.yml:931
- ArtifactName for package artifacts appears to be set to 'BlobArtifacts', which might be incorrect; consider using 'PackageArtifacts' if that is the intended artifact name for this stage.
ArtifactName: BlobArtifacts
eng/pipelines/templates/stages/vmr-build.yml:930
- [nitpick] Consider renaming 'PathtoPublish' to 'pathToPublish' to align with common camelCase naming conventions used in YAML pipelines.
PathtoPublish: $(Build.ArtifactStagingDirectory)/artifacts/packages
jkoritzinsky
approved these changes
Mar 5, 2025
akoeplinger
reviewed
Mar 5, 2025
| artifact: PackageArtifacts | ||
| - output: buildArtifacts | ||
| PathtoPublish: $(Build.ArtifactStagingDirectory)/artifacts/packages | ||
| ArtifactName: BlobArtifacts |
There was a problem hiding this comment.
this should be PackageArtifacts right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing doesn't like the pipeline artifacts entirely, yet:
dotnet/arcade#15590