Validate while publishing from the VMR #47264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move stages around so that publishing and validation are done in parallel after the final join. We don't need Maestro publishing to validate the assets
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR reorders the pipeline stages to enable publishing and validation to run in parallel after the final join, while decoupling Maestro publishing from asset validation.
- Introduces a new "Publish_Build_Assets" stage with a stage-level dependency on VMR_Final_Join.
- Repositions the ValidateAssetBaselines job within the VMR_Validation stage and removes a duplicate declaration of this job.
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/templates/stages/vmr-build.yml | Reorders stages by adding a publishing stage and cleans up duplicate validation jobs. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
eng/pipelines/templates/stages/vmr-build.yml:946
- Confirm that removing the job-level 'dependsOn: FinalJoin' is intentional and that the stage-level dependency 'dependsOn: VMR_Final_Join' fully covers the required dependency logic.
dependsOn: FinalJoin
eng/pipelines/templates/stages/vmr-build.yml:958
- [nitpick] Consider whether the job name 'ValidateAssetBaselines' could be more descriptive (for example including 'VMR') to improve clarity in the context of this pipeline.
- job: ValidateAssetBaselines
jkoritzinsky
approved these changes
Mar 4, 2025
ellahathaway
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move stages around so that publishing and validation are done in parallel after the final join. We don't need Maestro publishing to validate the assets