Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move branding information to targets file #47260

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 4, 2025

Fixes #47080

The Version property defined by Arcade is only available in .targets files. Move all the branding properties to D.B.targets.

Fixes #47080

The Version property defined by Arcade is only available in .targets files. Move those properties to D.B.targest.
@Copilot Copilot bot review requested due to automatic review settings March 4, 2025 21:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 4, 2025
@ViktorHofer ViktorHofer changed the title Move branding information that depends on Version to targets Move branding information to targets file Mar 4, 2025
@ViktorHofer
Copy link
Member Author

/backport to release/10.0.1xx-preview2

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Started backporting to release/10.0.1xx-preview2: https://github.com/dotnet/sdk/actions/runs/13663031623

@ViktorHofer ViktorHofer enabled auto-merge (squash) March 4, 2025 21:16
@ViktorHofer ViktorHofer merged commit 3c66f85 into main Mar 4, 2025
41 checks passed
@ViktorHofer ViktorHofer deleted the MoveBrandingInformationToTargets branch March 4, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NETSDKE2E] SDK version not displayed in .NET 10 Preview 2 installer UI
2 participants