Revert "Use pipeline artifacts for final artifacts" #47233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dotnet#46796)" This reverts commit 15e448c.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR reverts a previous change that used pipeline artifacts for final artifacts, switching back to using build artifacts for BlobArtifacts to ensure successful uploads to BAR.
- Reverts the artifact configuration for BlobArtifacts from pipelineArtifact back to buildArtifacts.
- Adjusts the relevant YAML keys to support the build artifact configuration.
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/templates/stages/vmr-build.yml | Reverts the artifact configuration for BlobArtifacts from pipelineArtifact to buildArtifacts. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
eng/pipelines/templates/stages/vmr-build.yml:925
- [nitpick] Consider renaming 'PathtoPublish' to 'pathToPublish' to align with common YAML key naming conventions.
PathtoPublish: $(Build.ArtifactStagingDirectory)/artifacts/assets
akoeplinger
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts part of commit 15e448c.
Unfortunately, the final push to BAR will attempt to generate the merged manifest to put in BlobArtifacts. Meaning that if we use pipeline artifacts for it, we can't upload to BAR, it will fail. Switch back to build artifacts for blobArtifacts. leave for pipeline and asset manifests.