Attempt to Fix and Re-enable HasIncludedFiles Test #47220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR aims to fix and re-enable the HasIncludedFiles test by updating test execution parameters and correcting expected file paths in the zip output.
- Re-enabled the previously skipped HasIncludedFiles test.
- Updated the execution command to explicitly use the Debug configuration.
- Revised assertions to match updated file paths in the generated output package.
Reviewed Changes
| File | Description |
|---|---|
| test/TestAssets/TestProjects/EndToEndTestApp/Program.cs | Added a basic console program as a test asset. |
| test/dotnet-pack.Tests/PackTests.cs | Re-enabled the test and updated execution parameters and zip entry assertions. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
test/dotnet-pack.Tests/PackTests.cs:91
- Confirm that using the '-c Debug' configuration is intentional and consistent with other tests, so that it does not cause unexpected behavior in the pack process.
.Execute("-c", "Debug")
test/dotnet-pack.Tests/PackTests.cs:102
- Double-check that the updated expected file paths ('newpath/pack1.txt' and 'anotherpath/pack2.txt') correctly reflect the intended output from the pack process.
.Should().Contain(e => e.FullName == "newpath/pack1.txt")
Forgind
approved these changes
Mar 9, 2025
| public void HasIncludedFiles() | ||
| { | ||
| var testInstance = _testAssetsManager.CopyTestAsset("EndToEndTestApp") | ||
| .WithSource(); | ||
|
|
||
| new DotnetPackCommand(Log) | ||
| .WithWorkingDirectory(testInstance.Path) | ||
| .Execute() | ||
| .Execute("-c", "Debug") |
There was a problem hiding this comment.
By default, it appears to be the release path. Therefore, the debug configuration was used to ensure the correct file path.
v-wuzhai
deleted the
dev/Jason/attempt-fix-reenable-hasincludedfiles-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.