Skip CanIgnoreTemplateGroupsWithConstraints #47173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been failing flakily with fairly high regularity, but I've almost always seen it fail on linux. Skipping on just linux for now
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
PR Overview
This PR addresses the flakiness of the "CanIgnoreTemplateGroupsWithConstraints" test on Linux by conditionally skipping it.
- Added a [SkipOnPlatform] attribute to skip the test on Linux.
- References GitHub issue CanIgnoreTemplateGroupsWithConstraints flaky test failing in CI #46212 for additional context.
Reviewed Changes
| File | Description |
|---|---|
| test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/TabCompletionTests.cs | Added SkipOnPlatform attribute to skip a flaky test on Linux |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/Microsoft.TemplateEngine.Cli.UnitTests/ParserTests/TabCompletionTests.cs:444
- Consider adding a brief descriptive message alongside the URL to clarify the specific reason for skipping this test on Linux.
[SkipOnPlatform(TestPlatforms.Linux, "https://github.com/dotnet/sdk/issues/46212")]
MiYanni
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been failing flakily with fairly high regularity, but I've almost always seen it fail on linux. Skipping on just linux for now