Move BuildWithNetFrameworkHostedCompiler to common #47067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
requested review from
jaredpar,
rainersigwald,
jjonescz,
RikkiGibson,
ViktorHofer,
chsienki and
Copilot
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Common.targets: Language not supported
- src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets: Language not supported
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
approved these changes
Feb 24, 2025
jjonescz
reviewed
Feb 24, 2025
jjonescz
approved these changes
Feb 24, 2025
jjonescz
reviewed
Feb 24, 2025
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.Common.targets
Show resolved
Hide resolved
Forgind
approved these changes
Mar 9, 2025
|
@ericstj is this ready for merge? |
baronfel
pushed a commit
to baronfel/sdk
that referenced
this pull request
Mar 11, 2025
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #46958, #45872
Revision of #41951
ApiCompat uses roslyn in the outer-build. Today it gets the wrong version - it resolves the default toolset version and not the one that the SDK might have used in the BuildWithNetFrameworkHostedCompiler case.
To fix this, move the calculation of BuildWithNetFrameworkHostedCompiler into common targets so that it will happen in the outer build.