Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0.3xx] Add analyzer redirecting VSIX #47021

Merged

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Feb 21, 2025

Backport of #42861 so it can be inserted into VS 17.14.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/575718

@jjonescz jjonescz marked this pull request as ready for review February 28, 2025 13:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR backports analyzer redirection changes to insert a VSIX component in Visual Studio 17.14. The changes include adding a new task to generate runtime analyzers SWR files, implementing analyzer assembly redirection logic, and introducing tests that verify redirection based on version compatibility.

Reviewed Changes

File Description
src/Installer/core-sdk-tasks/GenerateRuntimeAnalyzersSWR.cs Adds a new task for generating a runtime analyzers SWR file with folder and file inclusion logic
test/Microsoft.Net.Sdk.AnalyzerRedirecting.Tests/SdkAnalyzerAssemblyRedirectorTests.cs Introduces tests to validate analyzer redirection across different version scenarios
src/Microsoft.Net.Sdk.AnalyzerRedirecting/SdkAnalyzerAssemblyRedirector.cs Implements redirection logic that maps analyzer assembly names to their redirected paths and builds an analyzer map
src/Microsoft.Net.Sdk.AnalyzerRedirecting/AnalyzerRedirectingPackage.cs Provides a minimal package definition for VS integration

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

@jjonescz jjonescz merged commit 4dc9d20 into dotnet:release/9.0.3xx Mar 10, 2025
30 checks passed
@jjonescz jjonescz deleted the analyzer-redirecting-9.0.3xx branch March 10, 2025 16:39
@marcpopMSFT
Copy link
Member

FYI @v-wuzhai, jjonescz will be creating a VS insertion from this build as this change requires changes in the VS authoring. You should still do your planned Thursday staging for 3xx and it'll update the VS branch. He'll create a fork of that to do and test his VS authoring work so as not to risk the regularly weekly insertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants