-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logger and MSBuild --verbosity option to dotnet test #46909
Merged
mariam-abdulla
merged 7 commits into
main
from
dev/mabdullah/use-reporter-for-logging-in-dotnet-test
Feb 18, 2025
Merged
Add Logger and MSBuild --verbosity option to dotnet test #46909
mariam-abdulla
merged 7 commits into
main
from
dev/mabdullah/use-reporter-for-logging-in-dotnet-test
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
I will be adding a test to ensure that trace logging is working. |
Evangelink
reviewed
Feb 18, 2025
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Evangelink
approved these changes
Feb 18, 2025
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dotnet-test
command in the CLI, focusing on improving trace logging and adding verbosity options.Trace Logging Improvements:
VSTestTrace
withTestingPlatformTrace
in multiple files to standardize trace logging. (src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs
,src/Cli/dotnet/commands/dotnet-test/TestApplicationEventHandlers.cs
,src/Cli/dotnet/commands/dotnet-test/TestModulesFilterHandler.cs
) [1] [2] [3] [4] [5] [6] [7]TestingPlatformTrace
class to handle trace logging. (src/Cli/dotnet/commands/dotnet-test/TestingPlatformTrace.cs
)Verbosity Options:
BuildOptions
and related methods to allow setting verbosity levels during builds. (src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs
,src/Cli/dotnet/commands/dotnet-test/Options.cs
) [1] [2] [3]src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs
)These changes enhance the trace logging capabilities and provide more control over the verbosity of build outputs, improving the overall debugging and user experience.
Relates to #45927