Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logger and MSBuild --verbosity option to dotnet test #46909

Merged

Conversation

mariam-abdulla
Copy link
Member

@mariam-abdulla mariam-abdulla commented Feb 18, 2025

This pull request includes several changes to the dotnet-test command in the CLI, focusing on improving trace logging and adding verbosity options.

Trace Logging Improvements:

  • Replaced VSTestTrace with TestingPlatformTrace in multiple files to standardize trace logging. (src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs, src/Cli/dotnet/commands/dotnet-test/TestApplicationEventHandlers.cs, src/Cli/dotnet/commands/dotnet-test/TestModulesFilterHandler.cs) [1] [2] [3] [4] [5] [6] [7]
  • Added a new TestingPlatformTrace class to handle trace logging. (src/Cli/dotnet/commands/dotnet-test/TestingPlatformTrace.cs)

Verbosity Options:

  • Added verbosity option handling to BuildOptions and related methods to allow setting verbosity levels during builds. (src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs, src/Cli/dotnet/commands/dotnet-test/Options.cs) [1] [2] [3]
  • Included the verbosity option in the testing platform CLI command options. (src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs)

These changes enhance the trace logging capabilities and provide more control over the verbosity of build outputs, improving the overall debugging and user experience.

Relates to #45927

@Copilot Copilot bot review requested due to automatic review settings February 18, 2025 08:58
@mariam-abdulla mariam-abdulla requested a review from a team as a code owner February 18, 2025 08:58
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Feb 18, 2025
@mariam-abdulla mariam-abdulla removed the untriaged Request triage from a team member label Feb 18, 2025
@mariam-abdulla mariam-abdulla enabled auto-merge (squash) February 18, 2025 08:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

@mariam-abdulla
Copy link
Member Author

I will be adding a test to ensure that trace logging is working.

@mariam-abdulla mariam-abdulla merged commit fb527ca into main Feb 18, 2025
37 of 40 checks passed
@mariam-abdulla mariam-abdulla deleted the dev/mabdullah/use-reporter-for-logging-in-dotnet-test branch February 18, 2025 13:13
@mariam-abdulla mariam-abdulla changed the title Add TestingPlatformTrace and MSBuild --verbosity option to dotnet test Add Logger and MSBuild --verbosity option to dotnet test Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants