Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --framework, --os and --runtime in dotnet test #46861

Merged

Conversation

mariam-abdulla
Copy link
Member

This pull request includes several changes to improve the dotnet-test command functionality and refactor the codebase for better maintainability. The most important changes include adding new command-line options, refactoring the BuildOptions and BuildProperties classes, and updating the MSBuildUtility methods to accommodate these changes.

Improvements to command-line options:

Refactoring of BuildOptions and BuildProperties:

Updates to MSBuildUtility methods:

Other significant changes:

Relates to #45927

@Copilot Copilot bot review requested due to automatic review settings February 14, 2025 14:22
@mariam-abdulla mariam-abdulla requested a review from a team as a code owner February 14, 2025 14:22
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsForMultipleTFMs.cs: Evaluated as low risk
  • src/Cli/dotnet/commands/dotnet-test/TestApplication.cs: Evaluated as low risk
  • src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs: Evaluated as low risk
  • src/Cli/dotnet/commands/dotnet-test/Options.cs: Evaluated as low risk
  • src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs: Evaluated as low risk
  • src/Cli/dotnet/commands/dotnet-test/CliConstants.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs:85

  • The method ResolveRuntimeIdentifier could return an empty string if neither RuntimeOption, OperatingSystemOption, nor ArchitectureOption are provided. This might lead to unexpected behavior if not handled properly elsewhere.
return string.Empty;
@mariam-abdulla mariam-abdulla removed the untriaged Request triage from a team member label Feb 14, 2025
@mariam-abdulla mariam-abdulla enabled auto-merge (squash) February 14, 2025 14:29
@mariam-abdulla mariam-abdulla changed the title Support other options in dotnet test Support --framework, --os and --runtime in dotnet test Feb 14, 2025
mariam-abdulla and others added 16 commits February 17, 2025 08:23
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs

Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
@mariam-abdulla mariam-abdulla merged commit cb459eb into main Feb 17, 2025
38 of 40 checks passed
@mariam-abdulla mariam-abdulla deleted the dev/mabdullah/support-other-options-in-dotnet-test branch February 17, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants