-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --framework, --os and --runtime in dotnet test #46861
Merged
mariam-abdulla
merged 21 commits into
main
from
dev/mabdullah/support-other-options-in-dotnet-test
Feb 17, 2025
Merged
Support --framework, --os and --runtime in dotnet test #46861
mariam-abdulla
merged 21 commits into
main
from
dev/mabdullah/support-other-options-in-dotnet-test
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsForMultipleTFMs.cs: Evaluated as low risk
- src/Cli/dotnet/commands/dotnet-test/TestApplication.cs: Evaluated as low risk
- src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs: Evaluated as low risk
- src/Cli/dotnet/commands/dotnet-test/Options.cs: Evaluated as low risk
- src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs: Evaluated as low risk
- src/Cli/dotnet/commands/dotnet-test/CliConstants.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs:85
- The method ResolveRuntimeIdentifier could return an empty string if neither RuntimeOption, OperatingSystemOption, nor ArchitectureOption are provided. This might lead to unexpected behavior if not handled properly elsewhere.
return string.Empty;
Evangelink
reviewed
Feb 15, 2025
src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs
Outdated
Show resolved
Hide resolved
src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs
Outdated
Show resolved
Hide resolved
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
Outdated
Show resolved
Hide resolved
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
Outdated
Show resolved
Hide resolved
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
Outdated
Show resolved
Hide resolved
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
Outdated
Show resolved
Hide resolved
test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
…fferentOptions.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Evangelink
approved these changes
Feb 17, 2025
This was referenced Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the
dotnet-test
command functionality and refactor the codebase for better maintainability. The most important changes include adding new command-line options, refactoring theBuildOptions
andBuildProperties
classes, and updating theMSBuildUtility
methods to accommodate these changes.Improvements to command-line options:
src/Cli/dotnet/commands/dotnet-test/CliConstants.cs
: AddedShortHelpOptionKey
andTargetFramework
constants. [1] [2]src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs
: Added new options such asFrameworkOption
,OperatingSystemOption
, andRuntimeOption
to theTestingPlatformCommand
.Refactoring of
BuildOptions
andBuildProperties
:src/Cli/dotnet/commands/dotnet-test/Options.cs
: IntroducedBuildProperties
and refactoredBuildOptions
to includeBuildProperties
.src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs
: Updated methods to useBuildProperties
instead of individual properties. [1] [2] [3]Updates to
MSBuildUtility
methods:src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs
: AddedGetBuildOptions
andResolveRuntimeIdentifier
methods to handle new command-line options and refactored existing methods to use these changes. [1] [2] [3] [4]Other significant changes:
src/Cli/dotnet/commands/dotnet-test/SolutionAndProjectUtility.cs
: RefactoredGetProjectProperties
to handleTargetFramework
and addedGetModuleFromProject
andIsValidTargetFramework
methods. [1] [2]src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs
: UpdatedRun
method to use the newGetBuildOptions
method fromMSBuildUtility
. [1] [2]Relates to #45927