Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for help in dotnet test #46715

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

mariam-abdulla
Copy link
Member

@mariam-abdulla mariam-abdulla commented Feb 11, 2025

This pull request includes several updates to the test/dotnet-test.Tests/GivenDotnetTestBuildsAndRunsHelp.cs file and related project files to improve test consistency and accuracy. The most important changes are summarized below:

Updates to test constants and assertions:

  • Changed InlineData attributes to use TestingConstants instead of Constants for better clarity and consistency.
  • Updated regex patterns in assertions to match the correct output format and handle different directory separators. [1] [2]

Project file adjustments:

  • Removed unnecessary Compile directive for GivenDotnetTestBuildsAndRunsHelp.cs in dotnet.Tests.csproj.

Namespace updates:

  • Updated namespace usage to Microsoft.DotNet.Tools.Common for better alignment with the project structure.

Relates to #45927

@mariam-abdulla mariam-abdulla requested a review from a team as a code owner February 11, 2025 09:07
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Feb 11, 2025
@mariam-abdulla mariam-abdulla removed the untriaged Request triage from a team member label Feb 11, 2025
@mariam-abdulla mariam-abdulla merged commit b6eee93 into main Feb 11, 2025
39 checks passed
@mariam-abdulla mariam-abdulla deleted the dev/mabdullah/add-tests-for-dotnet-test-help branch February 11, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants