Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write help via dotnet test terminal logger #46686

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Write help via dotnet test terminal logger #46686

merged 3 commits into from
Feb 10, 2025

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Feb 10, 2025

Working towards #45927

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Feb 10, 2025
@nohwnd nohwnd marked this pull request as ready for review February 10, 2025 13:19
@nohwnd nohwnd requested a review from a team as a code owner February 10, 2025 13:19
Evangelink
Evangelink reviewed Feb 10, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to refactor more and move all the help display code to the terminal output class, this seems like its responsibility to decide how to print

@nohwnd
Copy link
Member Author

nohwnd commented Feb 10, 2025

We probably want to refactor more and move all the help display code to the terminal output class, this seems like its responsibility to decide how to print

I would much rather ship this than goldplate the code so we can get some feedback from users finally.

@Evangelink
Copy link
Member

It's probably 10min refactoring that will never be done otherwise.

@Evangelink Evangelink enabled auto-merge February 10, 2025 15:50
@Evangelink Evangelink merged commit d3a358d into dotnet:main Feb 10, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area-dotnet test untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nohwnd @Evangelink