-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support msbuild params in dotnet test #46562
Merged
mariam-abdulla
merged 9 commits into
main
from
dev/mabdullah/support-msbuild-params-option-in-dotnet-test
Feb 6, 2025
Merged
Support msbuild params in dotnet test #46562
mariam-abdulla
merged 9 commits into
main
from
dev/mabdullah/support-msbuild-params-option-in-dotnet-test
Feb 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
approved these changes
Feb 5, 2025
I still need to add a couple of integration tests. |
…est' of https://github.com/dotnet/sdk into dev/mabdullah/support-msbuild-params-option-in-dotnet-test
MarcoRossignoli
approved these changes
Feb 6, 2025
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dotnet-test
command to refactor and simplify the codebase. The most important changes involve the introduction of a newPathOptions
record, modifications to theBuildOptions
record, and updates to various methods to use these new structures. Additionally, some redundant methods and imports have been removed.Refactoring and simplification:
PathOptions
record and updatedBuildOptions
to includePathOptions
instead of individual path properties. (src/Cli/dotnet/commands/dotnet-test/Options.cs
)RunMSBuild
method to usePathOptions
for path properties. (src/Cli/dotnet/commands/dotnet-test/MSBuildHandler.cs
)GetProjects
method to simplify build and restore logic by combining MSBuild arguments. (src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs
) [1] [2]IsBinaryLoggerEnabled
,GetBuildParameters
, andGetCommands
. (src/Cli/dotnet/commands/dotnet-test/MSBuildUtility.cs
) [1] [2] [3]Command and option updates:
NoRestoreOption
andNoBuildOption
to use common options and forwarding functions. (src/Cli/dotnet/commands/dotnet-test/TestCommandParser.cs
,src/Cli/dotnet/commands/dotnet-test/TestingPlatformOptions.cs
) [1] [2]GetTestOptions
andGetBuildOptions
to utilize newPathOptions
and handle MSBuild arguments. (src/Cli/dotnet/commands/dotnet-test/TestingPlatformCommand.cs
) [1] [2]These changes aim to enhance code maintainability and readability by consolidating path-related options and removing unnecessary complexity.
Relates to #45927