-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dotnet run in case of --arch in dotnet test #46446
Use dotnet run in case of --arch in dotnet test #46446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see tests added for architecture with and without filter. Are the tests already existing?
Without filter, yes (we have RunTestProjectSolutionWithArchOption_ShouldReturnZeroAsExitCode) |
This pull request includes several changes to improve code readability and consistency in the
dotnet-test
command implementation. The most important changes involve making variables readonly where applicable, renaming variables for clarity, and refactoring methods to reduce redundancy.Codebase Improvements:
_output
and_executionIds
readonly inMSBuildHandler
andTestApplication
classes respectively to ensure immutability. [1] [2]modules
toprojects
to better reflect their purpose in theMSBuildHandler
andMSBuildUtility
classes. [1] [2] [3] [4] [5]RunAsync
and related methods inTestApplication
to useTestOptions
instead of multiple parameters, simplifying method signatures and improving readability. [1] [2] [3] [4] [5]BuildOptions
andTestOptions
records inOptions.cs
to include new fields and improve clarity.GetProjectProperties
inSolutionAndProjectUtility
to acceptglobalProperties
parameter, enhancing flexibility.Relates to #45927