-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor integraton tests for dotnet test #46333
Merged
mariam-abdulla
merged 20 commits into
main
from
dev/mabdullah/follow-up-on-dotnet-test-integration-tests
Jan 28, 2025
Merged
Refactor integraton tests for dotnet test #46333
mariam-abdulla
merged 20 commits into
main
from
dev/mabdullah/follow-up-on-dotnet-test-integration-tests
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
reviewed
Jan 27, 2025
test/Microsoft.NET.TestFramework/Utilities/DotnetVersionHelper.cs
Outdated
Show resolved
Hide resolved
...TestProjects/MSTestMetaPackageProjectWithMultipleTFMsSolution/TestProject/TestProject.csproj
Show resolved
Hide resolved
Co-authored-by: Jakub Jareš <me@jakubjares.com>
…s' of https://github.com/dotnet/sdk into dev/mabdullah/follow-up-on-dotnet-test-integration-tests
Evangelink
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes aimed at improving file handling, updating project configurations, and enhancing test utilities. The most important changes include the addition of new utility methods, renaming and refactoring classes, and updating project files to use a dynamic target framework.
File Handling Improvements:
FindFileInParentDirectories
method inPathUtility.cs
to locate files in parent directories.Code Refactoring:
msbuildExitCode
tomsBuildExitCode
for consistency inMSBuildHandler.cs
.projectFilePath
tofilePath
inBuildOrRestoreProjectOrSolution
method inMSBuildHandler.cs
.Test Utilities Enhancements:
ReadMSTestVersionFromProps
andUpdateProjectFileWithMSTestVersion
methods inTestAsset.cs
to handle MSTest version updates.DotnetVersionHelper
andRegexPatternHelper
classes inUtilities
to assist with version management and regex pattern generation. [1] [2]Project Configuration Updates:
.csproj
files to use$(CurrentTargetFramework)
instead of hardcoded target frameworks. [1] [2] [3] [4] [5]global.json
file from theMultiTestProjectSolutionWithDiscoveredTests
directory.Class Renaming:
Constants
toTestingConstants
inTestingConstants.cs
to better reflect its purpose.Relates to #45927