Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify CreateTempSubdirectory #45633

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

simplify CreateTempSubdirectory #45633

wants to merge 7 commits into from
+15 −74

Conversation

kasperk81
Copy link
Contributor

@kasperk81 kasperk81 commented Dec 27, 2024 •
edited
Loading

InternalAbstractions netstandard support is only needed by Microsoft.NET.TestFramework.csproj. for that CreateTempSubdirectory is using p/invoke for all dependents

making InternalAbstractions multi-framework same as Microsoft.NET.TestFramework.csproj to simplify CreateTempSubdirectory and deleting unused methods

#45631

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 27, 2024
@build-analysis build-analysis bot mentioned this pull request Dec 27, 2024
Open
3 tasks
@kasperk81
Copy link
Contributor Author

@marcpopMSFT @baronfel can we backport it to 9.0.2xx?

@marcpopMSFT marcpopMSFT requested a review from nagilson January 8, 2025 23:25
nagilson
nagilson reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on #45631 (comment)

@kasperk81
Copy link
Contributor Author

updated. it guarantees the desired file mode is set on unix without pinvoke

@build-analysis build-analysis bot mentioned this pull request Jan 9, 2025
Open
@kasperk81 kasperk81 mentioned this pull request Jan 9, 2025
Open
omajid
omajid reviewed Jan 10, 2025
View reviewed changes
tmds
tmds reviewed Jan 10, 2025
View reviewed changes
This was referenced Jan 10, 2025
Open
Open
@nagilson nagilson self-requested a review January 14, 2025 18:50
@kasperk81
Copy link
Contributor Author

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omajid omajid omajid left review comments

@tmds tmds tmds left review comments

@edvilme edvilme edvilme left review comments

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

@nagilson nagilson Awaiting requested review from nagilson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kasperk81 @omajid @tmds @edvilme @nagilson @KalleOlaviNiemitalo