-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #44461 to release/9.0.2xx #45594
Backport #44461 to release/9.0.2xx #45594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a straight backport, right?
Yep! |
…et#44461) Co-authored-by: Chet Husk <chusk3@gmail.com>
6acc5b3
to
bb0a6e5
Compare
Updating base to hopefully get to the state where the macOS arm64 test leg isn't required |
/backport to release/9.0.1xx |
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/12712743521 |
The template-engine test failure is flaky/spurious. Re-running (again). |
@marcpopMSFT how do you feel about merging on red here? this template engine macOS/x64 test isn't part of what's changed in this PR, and it's repeatedly failing. the same change backported to 9.0.1xx is green - and I'd like to be able to tell Tactics that this is already in 9.0.2xx when asking for the backport :) |
CanIgnoreTemplateGroupsWithConstraints is the failing test. I've seen it fail in another PR. I'll try to look into it. |
@Forgind let me know if you find any confirmation that this failure is systemic by later today and I'll merge on red. With the comment that 9.0.1xx PR is green, I'm inclined to let this in as is. |
I looked through a bunch of PRs and didn't see examples 🙃 I thought I'd seen it yesterday 🤷 No definitive confirmation. |
Well, I'll merge since it's passing in 1xx and that test should not be impacted by the changes in this PR. |
Backports the "Pin Base Image via Digest" feature from #44461 to the release/9.0.2xx branch.
cc @BeyondEvil