Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read global.json to decide to run dotnet test in vstest or testing platform mode #45418

Closed

Conversation

mariam-abdulla
Copy link
Member

@mariam-abdulla mariam-abdulla commented Dec 11, 2024

General

This is a draft proposal document for designing the global.json file for specifying the test runner with which we will be running the tests in the test projects.

Description

We have been working on improving the user experience in dotnet test by using Microsoft Testing Platform when running tests.
If you are interested in learning about the new testing platform, please check out this link.

We want to allow users to opt-in/opt-out this new experience through a global.json file where you specify the test runner with which you want to run your tests.

Suggestion

Please find below a sample of the global.json file

{
	"test" : {	
		"runner": {
			"name": "MicrosoftTestingPlatform"
		}
	}	
}

OR

{
	"test" : {	
		"runner": {
			"name": "VSTest"
		}
	}	
}

@mariam-abdulla mariam-abdulla requested a review from a team as a code owner December 11, 2024 15:36
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-dotnet test untriaged Request triage from a team member labels Dec 11, 2024
@mariam-abdulla mariam-abdulla added config-system-candidate Issues that could be solved cleanly if the .NET CLI had a git-like configuration system and removed untriaged Request triage from a team member labels Dec 11, 2024
Copy link
Member

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as starting point, we will keep this in hold till we have the doc approved with the correct names.

@MarcoRossignoli MarcoRossignoli marked this pull request as draft December 11, 2024 15:42

if (globalJson is not null)
{
var testSdkSection = globalJson["test-sdk"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks for "test-sdk" but the example in the PR description has "test-sdks".

Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests?

@mariam-abdulla
Copy link
Member Author

@Evangelink
Copy link
Member

Relates to #45927

@marcpopMSFT
Copy link
Member

Can you hold off on adding more capabilities into global.json until we've sorted out what we want the path forward to be per #45471. Per the discussion there, global.json may not be the preferred path forward for this and I think we need a partner discussion on this to settle on a direction.

@Evangelink
Copy link
Member

@marcpopMSFT could I please be included in the deisgn meetings) you will have? Also, do you have some kind of rough estimate of when you think we would have a solution so we can ensure we are on track for net10 release.

@Evangelink Evangelink deleted the dev/mabdullah/read-globaljson-in-dotnet-test branch February 7, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-dotnet test config-system-candidate Issues that could be solved cleanly if the .NET CLI had a git-like configuration system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants