-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read global.json to decide to run dotnet test in vstest or testing platform mode #45418
Read global.json to decide to run dotnet test in vstest or testing platform mode #45418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as starting point, we will keep this in hold till we have the doc approved with the correct names.
|
||
if (globalJson is not null) | ||
{ | ||
var testSdkSection = globalJson["test-sdk"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks for "test-sdk" but the example in the PR description has "test-sdks".
…//github.com/dotnet/sdk into dev/mabdullah/read-globaljson-in-dotnet-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some tests?
I already did, it's in the integration tests PR. |
…//github.com/dotnet/sdk into dev/mabdullah/read-globaljson-in-dotnet-test
Relates to #45927 |
Can you hold off on adding more capabilities into global.json until we've sorted out what we want the path forward to be per #45471. Per the discussion there, global.json may not be the preferred path forward for this and I think we need a partner discussion on this to settle on a direction. |
@marcpopMSFT could I please be included in the deisgn meetings) you will have? Also, do you have some kind of rough estimate of when you think we would have a solution so we can ensure we are on track for net10 release. |
General
This is a draft proposal document for designing the global.json file for specifying the test runner with which we will be running the tests in the test projects.
Description
We have been working on improving the user experience in dotnet test by using Microsoft Testing Platform when running tests.
If you are interested in learning about the new testing platform, please check out this link.
We want to allow users to opt-in/opt-out this new experience through a global.json file where you specify the test runner with which you want to run your tests.
Suggestion
Please find below a sample of the global.json file
OR