Execute GetTestsProject msbuild task if IsTestApplication property is true #44158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
nohwnd
approved these changes
Oct 14, 2024
nohwnd
deleted the
dev/mabdullah/FixIssueWithNonBuiltProjectsInDotnetTest
branch
|
Relates to #45927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small but important change to the
src/Layout/redist/MSBuildImports/Current/Microsoft.Common.targets/ImportAfter/Microsoft.TestPlatform.ImportAfter.targetsfile. The change modifies the condition for the_GetTestsProjecttarget to include an additional check forIsTestApplication.Most important change:
src/Layout/redist/MSBuildImports/Current/Microsoft.Common.targets/ImportAfter/Microsoft.TestPlatform.ImportAfter.targets: Modified the condition for the_GetTestsProjecttarget to include$(IsTestApplication) == 'true'to ensure that test applications are correctly recognized and processed.There was a bug that required us to build in CLI (dotnet build) before running dotnet test in case the project wasn't built before.