-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary of how we do localization in this repo #43202
Conversation
Is there any guide for external contributors when introducing new text that needs to be translated |
@WeihanLi what's missing from this guide? Adding the string to the resx, building, and submitting all of the xlf files along with the change should be sufficient for internal or external contributors. |
@marcpopMSFT For example, which of the following is recommended
<trans-unit id="hello">
<source>Hello</source>
<target state="new"></target>
<note />
</trans-unit>
<trans-unit id="hello">
<source>Hello</source>
<target state="new">Hello</target>
<note />
</trans-unit>
<trans-unit id="hello">
<source>Hello</source>
<target state="translated">你好</target>
<note />
</trans-unit> |
@WeihanLi, I understand from the text
that a developer who adds strings to resx, should only commit those xlf updates that the build system makes automatically, and should not otherwise edit the xlf files. |
@KalleOlaviNiemitalo is correct - developers should only ever create English strings. The process of running the build will generate all the required placeholder entire for the other language translations, which should be committed by the developer. |
get it, thanks very much @KalleOlaviNiemitalo @baronfel @marcpopMSFT |
I added a clarifying sentence but folks above already covered that devs should never be modifying the xlf files directly. |
No description provided.