Create a transport package for VS and VS authoring for analyzers #42451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 5 analyzers we want to include. Other teams are investigating a potentially mapping and final location. This is just a placeholder to generate the package. This is also WIP as I don't have the VS side of things finding the right files yet.
Put the analyzers in the SDK folder in a separate sub-folder for each.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jjonescz
reviewed
Aug 21, 2024
|
|
||
| AddFolder(sb, | ||
| @"AspNetCoreAnalyzers", | ||
| @"SDK\AspNetCoreAnalyzers"); |
There was a problem hiding this comment.
Should the target VS folder be something like DotNetSdk rather than just SDK?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42087
Some examples:
folder "InstallDir:\SDK\AspNetCoreAnalyzers\dotnet\cs"
file source="$(PkgVS_Redist_Common_Net_Core_SDK_RuntimeAnalyzers)\AspNetCoreAnalyzers\9.0.0-preview.5.24306.11\analyzers\dotnet\cs\Microsoft.AspNetCore.App.Analyzers.dll" vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe"
folder "InstallDir:\SDK\NetCoreAnalyzers\dotnet\cs"
file source="$(PkgVS_Redist_Common_Net_Core_SDK_RuntimeAnalyzers)\NetCoreAnalyzers\9.0.0-preview.5.24306.7\analyzers\dotnet\cs\System.Text.RegularExpressions.Generator.dll" vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe"
folder "InstallDir:\SDK\WindowsDesktopAnalyzers\dotnet"
file source="$(PkgVS_Redist_Common_Net_Core_SDK_RuntimeAnalyzers)\WindowsDesktopAnalyzers\9.0.0-preview.5.24306.8\analyzers\dotnet\System.Windows.Forms.Analyzers.dll" vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe"
folder "InstallDir:\SDK\SDKAnalyzers"
file source="$(PkgVS_Redist_Common_Net_Core_SDK_RuntimeAnalyzers)\SDKAnalyzers\9.0.100-dev\Sdks\Microsoft.NET.Sdk\analyzers\Microsoft.CodeAnalysis.NetAnalyzers.dll" vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe"
folder "InstallDir:\SDK\WebSDKAnalyzers\cs"
file source="$(PkgVS_Redist_Common_Net_Core_SDK_RuntimeAnalyzers)\WebSDKAnalyzers\9.0.100-dev\Sdks\Microsoft.NET.Sdk.Web\analyzers\cs\Microsoft.AspNetCore.Analyzers.dll" vs.file.ngenApplications="[installDir]\Common7\IDE\vsn.exe"