Update manifests when rolling back for install after updating from rollback file #37966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Workloads
untriaged
Forgind
added
Servicing-consider
and removed
untriaged
marcpopMSFT
reviewed
Jan 12, 2024
src/Cli/dotnet/commands/dotnet-workload/install/WorkloadInstallCommand.cs
Show resolved
Hide resolved
marcpopMSFT
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37958 for 2xx
Description
Manifest updates were disabled for Install if the user had previously updated --from-rollback-file, as that clearly indicates they wanted to pin to a specific set of versions, but that did not take into consideration if a user wanted to install --from-rollback-file, which similarly indicates they want a specific version but a different specific version. This takes that into account.
Customer Impact
Customers who called
dotnet workload update --from-rollback-file <file>thendotnet workload install --from-rollback-file <file>would have the second command not install the desired versions.Regression?
Yes. The decision to update or not update is made based on the install state file that was only added in 8.0.1xx.
Risk
Low
Tests
Manual test