-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated] Merge branch 'release/6.0.4xx' => 'release/7.0.1xx' #35169
[automated] Merge branch 'release/6.0.4xx' => 'release/7.0.1xx' #35169
Conversation
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…-merge-6.0.3xx-2023-08-08-1015
…-merge-6.0.4xx-2023-08-08-1015
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
c9955e0
to
0fa43a6
Compare
@dtivel I see you bumped |
@nagilson, see #33928 for full context. System.Security.Cryptography.Pkcs is a .NET Platform Extension and, therefore, not updated with .NET runtime updates. Several SDK components (i.e.: NuGet and MSBuild) use System.Security.Cryptography.Pkcs, but its update history is not great. By setting the version in the .NET SDK, the .NET SDK can bump the version globally. @marcpopMSFT, applied this change in .NET 6.0.1xx and 6.0.3xx SDK's. This change applied the same version bump to the .NET 6.0.4xx SDK. |
Since this is codeflow into 7, I don't think we should take the change as is as we wouldn't want the 6.0.4 version. We can either remove the change entirely into 7.0.1xx or change it to target the latest 7.0 version of that package (which is 7.0.3) |
I agree. #35158 was only meant for 6.0.4xx. |
That's the only relevant change here so I'm closing this. Thank you for providing such great context. |
note that it'll probably keep showing up in these branch merges until we have a real change we want to take and we remove that commit from the flow. |
I detected changes in the release/6.0.4xx branch which have not been merged yet to release/7.0.1xx. I'm a robot and am configured to help you automatically keep release/7.0.1xx up to date, so I've opened this PR.
This PR merges commits made on release/6.0.4xx by the following committers:
Instructions for merging from UI
This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.
If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.
Instructions for merging via command line
Run these commands to merge this pull request from the command line.
or if you are using SSH
After PR checks are complete push the branch
Instructions for resolving conflicts
Instructions for updating this pull request
Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/6.0.4xx-to-release/7.0.1xx'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.
or if you are using SSH
Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.