Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'release/6.0.4xx' => 'release/7.0.1xx' #35169

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/6.0.4xx branch which have not been merged yet to release/7.0.1xx. I'm a robot and am configured to help you automatically keep release/7.0.1xx up to date, so I've opened this PR.

This PR merges commits made on release/6.0.4xx by the following committers:

  • marcpopMSFT
  • dtivel
  • v-wuzhai
  • vseanreesermsft
  • dotnet-maestro[bot]
  • dotnet-bot
  • mmitche
  • Forgind

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/6.0.4xx
git pull --ff-only
git checkout release/7.0.1xx
git pull --ff-only
git merge --no-ff release/6.0.4xx

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/sdk HEAD:merge/release/6.0.4xx-to-release/7.0.1xx
or if you are using SSH
git push git@github.com:dotnet-maestro-bot/sdk HEAD:merge/release/6.0.4xx-to-release/7.0.1xx

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/6.0.4xx-to-release/7.0.1xx'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/6.0.4xx-to-release/7.0.1xx release/7.0.1xx
git pull https://github.com/dotnet-maestro-bot/sdk merge/release/6.0.4xx-to-release/7.0.1xx
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/sdk HEAD:merge/release/6.0.4xx-to-release/7.0.1xx
or if you are using SSH
git checkout -b merge/release/6.0.4xx-to-release/7.0.1xx release/7.0.1xx
git pull git@github.com:dotnet-maestro-bot/sdk merge/release/6.0.4xx-to-release/7.0.1xx
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet-maestro-bot/sdk HEAD:merge/release/6.0.4xx-to-release/7.0.1xx

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

@v-wuzhai v-wuzhai requested a review from a team September 6, 2023 09:58
@nagilson
Copy link
Member

nagilson commented Sep 6, 2023

@dtivel I see you bumped System.Security.Cryptography.Pkcs here: https://github.com/dotnet/sdk/pull/35158/files but that was also adding the package to DARC for the first time. Where/why is this package being consumed now? I didn't see it being used in the SDK anywhere

@nagilson nagilson removed the untriaged Request triage from a team member label Sep 6, 2023
@dtivel
Copy link
Contributor

dtivel commented Sep 6, 2023

@nagilson, see #33928 for full context.

System.Security.Cryptography.Pkcs is a .NET Platform Extension and, therefore, not updated with .NET runtime updates. Several SDK components (i.e.: NuGet and MSBuild) use System.Security.Cryptography.Pkcs, but its update history is not great. By setting the version in the .NET SDK, the .NET SDK can bump the version globally.

@marcpopMSFT, applied this change in .NET 6.0.1xx and 6.0.3xx SDK's. This change applied the same version bump to the .NET 6.0.4xx SDK.

@marcpopMSFT
Copy link
Member

Since this is codeflow into 7, I don't think we should take the change as is as we wouldn't want the 6.0.4 version. We can either remove the change entirely into 7.0.1xx or change it to target the latest 7.0 version of that package (which is 7.0.3)

@dtivel
Copy link
Contributor

dtivel commented Sep 6, 2023

I agree. #35158 was only meant for 6.0.4xx.

@nagilson
Copy link
Member

nagilson commented Sep 6, 2023

That's the only relevant change here so I'm closing this. Thank you for providing such great context.

@nagilson nagilson closed this Sep 6, 2023
@marcpopMSFT
Copy link
Member

note that it'll probably keep showing up in these branch merges until we have a real change we want to take and we remove that commit from the flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants