Revert "[main] Update dependencies from dotnet/command-line-api (#29131)" #33146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
requested review from
a team,
andriipatsula,
ericstj,
joperezr,
tmat,
arkalyanms and
sharwell
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ViktorHofer
reviewed
Jun 9, 2023
| @@ -22,7 +22,7 @@ internal static class ValidatePackage | |||
| bool enableRuleAttributesMustMatch, | |||
| string[]? excludeAttributesFiles, | |||
| bool enableRuleCannotChangeParameterName, | |||
| string? packagePath, | |||
| string packagePath, | |||
There was a problem hiding this comment.
I think this is a strict revert of the prior change.
There was a problem hiding this comment.
Then the state before the command line api change was made, was incorrect. Please revert this change as we accept a nullable package path string in PackageValidation (and later throw).
There was a problem hiding this comment.
Sorry, this is currently blocking codeflow to installer and we don't want to delay further. It'll come back with the revert of the revert.
marcpopMSFT
approved these changes
Jun 9, 2023
MichaelSimons
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f8831a6.
We're reverting this because it blocks installer codeflow. We need to sychronize the changes with other repos that codeflow S.CL so that flow is blocked as little as possible.