Add support for EnableRequestDelegateGenerator flag #29982
Conversation
dotnet-issue-labeler
bot
added
the
Area-AspNetCore
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToUseAnalyzers.cs
Outdated
Show resolved
Hide resolved
| @@ -5,13 +5,21 @@ Usage: | |||
| dotnet new TestAssets.PostActions.RunScript.Basic [options] [template options] | |||
|
|
|||
| Options: | |||
| -n, --name <name> The name for the output being created. If no name is specified, the name of the output directory is used. | |||
| -n, --name <name> The name for the output being created. If no | |||
There was a problem hiding this comment.
Is this change supposed to change width of output?
this looks suspicious
There was a problem hiding this comment.
src/Tests/dotnet-new.Tests/Approvals/DotnetNewHelpTests.CanShowHelpForTemplate_MatchOnLanguage.verified.txt also changed from -f, --framework <net6.0|net7.0|net8.0> to -f, --framework <choice>, i.e. it's not merely a matter of width.
There was a problem hiding this comment.
In this example it's just width, and it is a concern.
There was a problem hiding this comment.
There's a fairly chunky delta between the SDK this PR updates to and the one that we were previously targeting so I'm not sure what exactly caused this change.
I will say that enforcing a consistent line width on the console output seemed like a sensible bug fix to me.
Where is the repo that these code changes are sourced from?
There was a problem hiding this comment.
This may be a change in System.CommandLine. @baronfel
There was a problem hiding this comment.
Hmmm, I think there might be an error on my part here. The whitespace inconsistencies replicate on my local machine (where I produced the snapshots), but it looks like the tests on the build machines emit outputs without a wrapped width.
Is there a chance there is an option on my local machine that causes this behavior?
|
I resolved a few issues that sprung up during the SDK update. There is one remaining issue affecting the tests:
which seems to originate from dotnet/runtime@b2dc37b. @MichalStrehovsky Any thoughts on what might've triggered this in our build set? I was under the impression that the Helix machines were 64-bit so surprised the error is surfacing... |
I think this will be fixed by dotnet/runtime#80752. |
Part of dotnet/aspnetcore#45524.
This new source generator is shipped as part of the Microsoft.AspNetCore.App ref pack. We want to have it disabled by default so we add some build logic to the web template to disable it unless explicitly enabled by setting the
EnableRequestDelegateGeneratorbuild property.