Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/runtime #25317

Merged
merged 6 commits into from
May 17, 2022
Merged

[main] Update dependencies from dotnet/runtime #25317

merged 6 commits into from
May 17, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 10, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20220516.11
  • Date Produced: May 17, 2022 4:37:45 AM UTC
  • Commit: f4c60fd235fa8db19567ea7048cabec11ce9ce36
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
ca63ced 
…0509.7

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.5.22258.4 -> To Version 7.0.0-preview.5.22259.7
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@danmoseley
Copy link
Member

All the failures I looked at were the same:

    Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmBuildIncrementalismTest.Build_GzipCompression_IsIncremental [FAIL]
      System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace:
        /_/src/Tests/Microsoft.NET.TestFramework/AspNetSdkTest.cs(25,0): at Microsoft.NET.TestFramework.AspNetSdkTest..ctor(ITestOutputHelper log)
           at InvokeStub_WasmBuildIncrementalismTest..ctor(Object, Object, IntPtr*)
           at System.Reflection.ConstructorInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

where the actual test varies.

@danmoseley
Copy link
Member

@steveharter I wonder whether this was caused by your change. Seems that an object is getting nulled out during a reflection invoke. If you agree, could you take a look?

@danmoseley
Copy link
Member

Linking dotnet/runtime#67917

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
f86e8da 
…0511.1

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.5.22258.4 -> To Version 7.0.0-preview.5.22261.1
@steveharter
Copy link
Member

@steveharter I wonder whether this was caused by your change. Seems that an object is getting nulled out during a reflection invoke. If you agree, could you take a look?

Looking now; it appears that Assembly.GetCallingAssembly() is not correct in this case.

@steveharter steveharter mentioned this pull request May 12, 2022
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
72a01ce 
…0511.13

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.5.22258.4 -> To Version 7.0.0-preview.5.22261.13
@danmoseley
Copy link
Member

Latest update still doesn't have this fix -- it's 05113 and the fix was merged today:

commit 8420dae8e84e03b7658a21f4b18831a8a2f0db79
Author: Steve Harter steveharter@users.noreply.github.com
Date: Thu May 12 08:09:19 2022 -0500

Fix Assembly.GetCallingAssembly() (#69225)

so let's wait for the next.

dotnet-maestro bot added 2 commits May 13, 2022 12:30
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
39c51d4 
…0513.2

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.5.22258.4 -> To Version 7.0.0-preview.5.22263.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
cbbb3d3 
…0513.6

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , System.CodeDom , Microsoft.NET.HostModel , Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Host.win-x64 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.5.22258.4 -> To Version 7.0.0-preview.5.22263.6
@jkotas jkotas mentioned this pull request May 15, 2022
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
f134734 
…0516.11

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , System.Resources.Extensions , System.Reflection.MetadataLoadContext , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , System.CodeDom , Microsoft.NETCore.App.Host.win-x64 , Microsoft.Extensions.DependencyModel , Microsoft.DotNet.ILCompiler , Microsoft.NET.HostModel , Microsoft.NETCore.App.Ref , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-preview.5.22258.4 -> To Version 7.0.0-preview.5.22266.11
@ericstj
Copy link
Member

ericstj commented May 17, 2022

Looks like this build should be passing again once the Ubuntu leg completes. 🤞

@dotnet-maestro dotnet-maestro bot merged commit 5af4822 into main May 17, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-90071ec5-287e-4651-8ed7-b02ae2241b1f branch May 17, 2022 14:42
@dsplaisted dsplaisted mentioned this pull request May 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-CodeFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danmoseley @steveharter @ericstj