Initial Support for PredefinedCultureOnly property #18672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
tarekgh
changed the title
tarekgh
force-pushed
the
PredefinedCulturesOnlySupport
branch
from
aa93e39
to
4a14f98
Compare
tarekgh
force-pushed
the
PredefinedCulturesOnlySupport
branch
from
75b2eba
to
b5c39d3
Compare
dsplaisted
reviewed
Jul 7, 2021
src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildALibrary.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 7, 2021
| @@ -59,7 +59,7 @@ | |||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | |||
| <CopyToPublishDirectory>Never</CopyToPublishDirectory> | |||
| </Content> | |||
|
|
|||
There was a problem hiding this comment.
We should be setting the <PredefinedCulturesOnly> property in the top PropertyGroup of this file.
There was a problem hiding this comment.
@dsplaisted I have returned back the changes in GivenThatWeWantToPublishAProjectWithAllFeatures.cs and TestApp as @eerhardt suggested to keep it to test the behavior when enabling the property in down-level version even if it will not have any runtime effect.
eerhardt
reviewed
Jul 7, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
…rary.cs Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
…rary.cs Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
tarekgh
commented
Jul 7, 2021
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
Outdated
Show resolved
Hide resolved
|
@dsplaisted are we good to merge? or you have more comments? |
|
@tarekgh I've merged it |
v-wuzhai
pushed a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
added a commit
that referenced
this pull request
May 7, 2024
Co-authored-by: Matt Mitchell <mmitche@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are changing the Invariant Globalization mode behavior in .NET 6.0 to force it to throw exception by default when creating non-Invariant cultures dotnet/runtime#54247. The behavior can be controlled by a config switch
System.Globalization.PredefinedCulturesOnlythat we need to support it through the SDK to have msbuild property.