Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetadataUpdaterSupport property #18670

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jul 1, 2021

While writing some docs I noticed that the feature switch added in dotnet/runtime#54590 hadn't been defined in the SDK yet. Also adds some existing switches to the test.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for catching this and adding it.

Copy link
Member

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the COM and native host properties to this test as well. I'm a little confused with the difference between this test and GivenThatWeWantToRunILLink and am happy you are covering this one.

@sbomer
Copy link
Member Author

sbomer commented Jul 1, 2021

I think this test is supposed to cover all RuntimeHostConfigurationOptions, whether trim-enabled or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants