Add support for SunOS-like platforms #12198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dsplaisted, @eerhardt, like FreeBSD, we can cross-compile SDK for illumos distros with these minimal set of changes. This matches the implementation done in host. |
eerhardt
reviewed
Jun 25, 2020
| @@ -13,7 +13,9 @@ internal enum Platform | |||
| Windows = 1, | |||
| Linux = 2, | |||
| Darwin = 3, | |||
| FreeBSD = 4 | |||
| FreeBSD = 4, | |||
| illumos = 5, | |||
There was a problem hiding this comment.
Is this supposed to start with a lower case character?
There was a problem hiding this comment.
The official casing is lowercase (to disambiguate letters i and lowercase l, like iOS). In the output we print the value as is.
eerhardt
reviewed
Jun 25, 2020
|
If there are no other comments here, can this be merged? Thanks. |
eerhardt
approved these changes
Jul 13, 2020
19 tasks
dsplaisted
reviewed
Oct 30, 2020
| switch (versionDescription) | ||
| { | ||
| case string version when version.StartsWith("omnios"): | ||
| result.Id = "OmniOS"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes required to cross-compile and use SDK on illumos distors and Oracle Solaris OS.