-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The executable generated from dotnet publish -r linux-x64
doesn't have "x" permission
#1331
Comments
@kichalla This issue was present in Preview1 - do you know why it was not surfaced then and is surfacing only now? Is this because it was masked by the Nuget bug? @livarcocc We should consider taking this for Preview2 SDK. What is the timeline for it? |
Yes, this issue was masked by the Nuget bug. Also I couldn't report this earlier because I was waiting for a CLI which had this Nuget fix. |
I can confirm the repro steps (Ubuntu 14) The workarounds for now:
I'll start working on the fix. |
For standalone app, which is where this is a bug, this workaround is not correct. I think we should strive to get a fix in today so that we can have the potential to take in the SDK. @livarcocc which branch should @steveharter prepare the fix in? |
@steveharter Do you have an ETA on the PR? |
Soon (EOD); verifying fix. Planning on targeting master branch first. There are two approaches to the implementation: use File.Copy(apphost, testconsole) to copy the permissions from apphost to the testconsole and then replace the contents, or do a raw chmod +x on testconsole. I'm taking the File.Copy approach as a raw chmod will introduce calls into unix interop assemblies which is riskier. |
See referenced PR; Tests are failing locally because the apphost being restored does not have the execute bit set. Need a newer version of NuGet? Note: I must need permissions to the sdk repo as I can't modify any properties, including adding a reviewer. |
@livarcocc @nguerrera Can you please help @steveharter with the issues above and also help answer the question around Nuget version as we should be taking this fix for Preview2. CC @leecow as well. |
It's possible that NuGet version in master is too old. We haven't RIed in a while. PR should target 2.0 branch |
Closing since the PR is now merged. |
@steveharter fixed my issue! thank you! |
…0200310.1 (dotnet#1331) - Microsoft.AspNetCore.Analyzers - 5.0.0-preview.3.20160.1 - Microsoft.AspNetCore.Components.Analyzers - 5.0.0-preview.3.20160.1 - Microsoft.AspNetCore.Mvc.Api.Analyzers - 5.0.0-preview.3.20160.1 - Microsoft.AspNetCore.Mvc.Analyzers - 5.0.0-preview.3.20160.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Related issues:
Repro steps:
NuGet.config
with the following content:<RuntimeIdentifier>linux-x64</RuntimeIdentifier>
and save the file./testconsole
Expected:
Hello World!
Actual:
bash: ./testconsole: Permission denied
cc @steveharter @gkhanna79
The text was updated successfully, but these errors were encountered: