Merge from dotnet/runtime #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MacOS single-file support changes Use dysymtab_command to just load the extern/export symbols. Don't read the whole symbol string table; read the symbol name a char at a time. dotnet/runtime#38901 * Don't add null to symbol name * Code review feedback * Code review feedback * Code review feedback fix
…(#51213) * add Task-based DisconnectAsync and refactor APM methods on top of it * fix BeginDisconnect to throw synchronously and add relevant tests * remove #region stuff in Socket.cs and add link to github issue Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
* rework request retry logic to be based off a fixed retry limit (MaxConnectionFailureRetries) instead of isNewConnection logic * be more conservative about request retries -- only allow on receiving EOF or GOAWAY from the server Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
…ess dotnet/runtime-assets (#51307) * Update dependencies from https://github.com/dotnet/arcade build 20210414.5 Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageValidation , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk From Version 6.0.0-beta.21212.6 -> To Version 6.0.0-beta.21214.5 * Update dependencies from https://github.com/dotnet/xharness build 20210415.2 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.21214.1 -> To Version 1.0.0-prerelease.21215.2 * Update dependencies from https://github.com/dotnet/arcade build 20210415.5 Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageValidation , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk From Version 6.0.0-beta.21212.6 -> To Version 6.0.0-beta.21215.5 * Update dependencies from https://github.com/dotnet/runtime-assets build 20210415.1 System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData From Version 6.0.0-beta.21212.1 -> To Version 6.0.0-beta.21215.1 * Update dependencies from https://github.com/dotnet/arcade build 20210416.2 Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageValidation , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk From Version 6.0.0-beta.21212.6 -> To Version 6.0.0-beta.21216.2 * Update dependencies from https://github.com/dotnet/icu build 20210416.2 Microsoft.NETCore.Runtime.ICU.Transport From Version 6.0.0-preview.4.21212.2 -> To Version 6.0.0-preview.5.21216.2 * Update dependencies from https://github.com/dotnet/xharness build 20210416.1 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 1.0.0-prerelease.21214.1 -> To Version 1.0.0-prerelease.21216.1 * Update dependencies from https://github.com/dotnet/runtime-assets build 20210416.1 System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData From Version 6.0.0-beta.21212.1 -> To Version 6.0.0-beta.21216.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Add JSON source generator * Address review feedback * Address review feedback * Align project structure with src-gen conventions * Fix enum (de)serialization
* simplify trimming non significant digits * PR feedback * fixed formatting
Allows us to test the documented single file behaviors. Not adding a new `PlatformDetection` thing for this since we don't really have a way to detect single file that wouldn't end us up testing a tautology.
.vsconfig was missing the missing the .NET 4.8 Targetting pack option. Fix #51455
…vior in tests (#50930) This PR fixed QuicStreamTests.BasicTest and QuicStreamTests.MultipleReadsAndWrites. Contributes to #49157
* Create standalone class for CallConv parsing.
Ref: xamarin/xamarin-macios#11175 (comment), https://unicode-org.atlassian.net/browse/ICU-21591 There seems to be a bug in ICU that leads to deadlock when the time zone data are stripped. Since dotnet/icu uses the same stripping of data on all the platforms the time zone data are also not present on iOS/tvOS or any platform that consumes it. So even if the deadlock itself is resolved at some point it makes sense to use the same implementation for all the platforms that rely on the filtered app-local ICU data. I also enabled to code path on MacCatalyst to keep it consistent with iOS. I am open to change that. Android may need to be treated the same way too.
* initial backport of CBOR documentation * apply manual fixups to documentation * Update src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Reader/CborReader.Map.cs Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> * Update src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Writer/CborWriter.Map.cs Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Non-portable builds are used by source-build and also use for testing/debugging things, like trying out upcoming versions of OpenSSL.
- Add two `ConfigureHostOptions` extension methods - Two overloads exist, per [Maryam's comment](https://github.com/dotnet/runtime/pull/49502/files#r596466330) - Add corresponding unit tests to ensure these new methods function correctly Fixes #48743
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Valentin Grigorev <valentin.grigorev@jetbrains.com>
* Address remaining warnings from DataContractSerialization * Refactor MemberTypes declaration * Remove Unused UnconditionalSuppressMessages * Addressing some PR Feedback * Suppress MakeGenericMethod calls in AccessorBuilder * Suppressing error in NullPrimitiveDataContract constructor * Suppress other MakeGenericMethod linker warnings * Address remaining feedback and move trimmer string to DataContract * Addressing some nits * Fix typo and remove unnecesary usings
* Refactoring GenTreeJitIntrinsic to expose SimdSize and SimdBaseType via methods * Updating the JIT to pass through the CORINFO_TYPE for hardware intrinsics * Adding support for Vector<nint> and Vector<nuint> to managed code * Updating the vector tests to cover nint and nuint * Recognize Vector<nint> and Vector<nuint> in the JIT * Updating Vector64/128/256<T> NotSupportedTest metadata to include type name * Updating the Vector64/128/256<T> tests to have NotSupported validation for nint/nuint * Splitting ThrowHelper.ThrowForUnsupportedVectorBaseType into separate functions for Numerics vs Intrinsics * Updating Utf16Utility.Validation to directly use Vector<nuint> * Don't use the auxiliary type to hold a SIMD type, since it can be trivially pulled from the operand instead * Split the mono handling for ThrowForUnsupportedVectorBaseType into ThrowForUnsupportedNumericsVectorBaseType and ThrowForUnsupportedIntrinsicsVectorBaseType * Add basic handling for MONO_TYPE_I and MONO_TYPE_U to simd-intrinsics.c * Ensure simd-intrinsics.c in Mono handles `MONO_TYPE_I` and `MONO_TYPE_U` on relevant code paths * Ensure we don't assert when encountering synthesized Vector128<nint> handles * Applying formatting patch * Fix the handling for Crc32 and Crc32C on ARM64 * Updating Mono mini-amd64 to handle MONO_TYPE_I and MONO_TYPE_U for SIMD operations * Handle OP_XCOMPARE.CMP_GE_UN for MONO_TYPE_U * Handle MONO_TYPE_I and MONO_TYPE_U for Vector types in mini-llvm
* Run SPMI collection on libraries-tests * Only run for libraries-tests and change GUID * fix error * fix the collection name * fix the timeoutInMinutes * Download libraries test artifacts * try to fix the libs+tests artifacts name * Use artifacts name as is * Fix the libraries test artifacts name * Use librares_test.zip * Modify the filter to unzip all *Tests.dll files * Revert "Modify the filter to unzip all *Tests.dll files" This reverts commit b62f7132ec084453495a92a3e336688585366908. * Try to unzip libraries_zipped * overwriteExistingFiles=true * Fix the asset extension - Also exclude files present in core_root * fix artifacts name * remove extra . * Ignore permission error * Copy common test files in CORE_ROOT - And do not copy not *.Tests.dll" for PMI * Perform collection for all libraries_tests assets * Add UnicodeEncodeError EH * Add PermissionError for copy2 * Copy all the test assests to core_root * Make input_directory readonly * make ch_mod recursive * Add option of error_limit to superpmi.py * Pass -failureLimit flag to parallel mode * Revert "Only run for libraries-tests and change GUID" This reverts commit 7f4cdda9cf4f49fc21a354f616a67554f65cd6ea.
SPMI wasn't capturing enough data for PGO schemas that had class profiles, leading to replay failures.
Annotated public System.Console APIs throwing PNSE on Android. Part of #47911.
* eh fix * test change that inadvertently got checked in earlier * Suppresses the trimmer warning on TypeAnalysis ctor * Incorporating FB * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Update src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Update src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Fix DynamicDependency as per PR feedback * an earlier change got reverted * fixed proj file netcore app condition check * fixed NETCORE_ENGINEERING_TELEMETRY build failures * fixeing another NETCORE_ENGINEERING_TELEMETRY build failures * Adding RequiresUnreferencedCode to TypeAnalysis ctor instead of suppressing the warning to get FB, not fully fixed * PR FB and suppressing warnings for safe calls * propagated the warning all the way up * CI build break fix for one file * excluding NativeRTEventSrc from being build in a project * Missed couple of supppressions on NativeRTEventSrc * build break fixes * Trimmer warning fix related to EventSource manifest creation * incorporate fb * fix build break in some configs * comment feedback * build break Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…Server as a Mono runtime component. (#50837) Implementation of Mono runtime component infrastructure, https://github.com/dotnet/runtime/blob/main/docs/design/mono/components.md. This commit also includes a port of Mono EventPipe/DiagnosticsServer library over to new runtime component infrastructure. Before all packaging/deploy have been fixed for platforms that will switch over to hosting components as shared libraries, all components will be build and linked using the static linkage scenario outline in document above. Once package and deploy is resolved for dynamic linking scenarios, we will switch this for corresponding platforms in follow up commits.
Also change the storage model to SafeEvpPKeyHandle, only import and export use legacy SafeRsaHandle.
* fix zero byte send on linux and update tests Co-authored-by: Geoffrey Kizer <geoffrek@windows.microsoft.com>
…51466) * Add metadata update handler to System.ComponentModel.TypeConverter * Update src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs
* Remove pinning in BufferedFileStreamStrategy * Simplify code/synchronization in ValueTaskSource
…riting from a zero-sized class that inherits from another zero-sized class. (#50861)
It's 14 hours of lectures about how .NET GC is implemented.
* Disable source generators from binplacing * Ensure APICompat doesn't run for non-Source projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.