Replace old ReflectionMethodBodyScanner with the illink-based one #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
added
area-NativeAOT-coreclr
| @@ -492,7 +481,7 @@ public override void GetDependenciesDueToAccess(ref DependencyList dependencies, | |||
| public override void GetDependenciesDueToAccess(ref DependencyList dependencies, NodeFactory factory, MethodIL methodIL, MethodDesc calledMethod) | |||
| { | |||
| bool scanReflection = (_generationOptions & UsageBasedMetadataGenerationOptions.ReflectionILScanning) != 0; | |||
| if (scanReflection && FlowAnnotations.RequiresDataflowAnalysis(calledMethod)) | |||
| if (scanReflection && Dataflow.ReflectionMethodBodyScanner.RequiresReflectionMethodBodyScannerForCallSite(FlowAnnotations, calledMethod)) | |||
There was a problem hiding this comment.
This was an ooops. We were running the analysis less often than we should (we need to run it not just when calling into an annotated method, but also if the method is an intrinsic. Most, but not all, intrinsics have annotations.
MichalStrehovsky
removed
the
* NO MERGE *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required beefing up the illink-based one a little:
typeof(SomeType<>).MakeGenericType(otherType).GetMethod("Foo")work for reference-typeotherType. This is a heuristic.MakeGenericTypejust needs to warn as being unsafe.Enum.GetValuesandMarshal.SizeOf. As a bonus, this hooks into the flow analysis infra, so we can potentially figure out more use cases. As another bonus, there's now a warning.Lost features:
typeof(T) == typeof(Foo)that was trying to avoid seeingFooas constructed (with a fully populated vtable). This can be added later; I'm leaving the compiler infra inplace.