Support cross-architecture compilation in ILC #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonLapounov
force-pushed
the
ILC_CrossArchCompilation
branch
from
3441dc9
to
9de2d06
Compare
jkotas
reviewed
Jan 26, 2021
| @@ -103,7 +103,7 @@ stages: | |||
| isOfficialBuild: ${{ variables.isOfficialBuild }} | |||
| timeoutInMinutes: 90 | |||
| testGroup: innerloop | |||
| buildArgs: -s nativeaot+libs+nativeaot.packages -c release | |||
| buildArgs: -s nativeaot.objwriter+nativeaot+libs+nativeaot.packages -c release | |||
There was a problem hiding this comment.
We should watch next couple official builds and verify that they succeed.
jkotas
reviewed
Jan 26, 2021
| <TargetSpec>$(TargetOSComponent)_$(TargetArchitecture)_$(TargetArchitecture)</TargetSpec> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- On Windows we can re-use PGO-optimized clrjit.dll produced by the build for AOT compilation. |
There was a problem hiding this comment.
I am not sure whether it is worth the trouble that it may cause (e.g. with symbols), but since you have done it we can give it a try.
There was a problem hiding this comment.
This logic is copied from crossgen2.csproj.
This was referenced Jan 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Build
clr.alljitssubset by default and publish resulting JIT libraries with ILC.• Choose JIT library in ILC dynamically, like we do in crossgen2.
• In official builds, build
objwriterlibrary by requestingnative.objwritersubset and publish it with ILC.• If
native.objwritersubset was not requested, extractobjwriterlibrary from Microsoft.DotNet.ILCompiler package.• Remove extra backslashes in paths.
Fixes #63 and #218.