Delete RuntimeTypeHandle.GetValueInternal #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetValueInternal may or may not go away from RyuJIT at some point. We originally used this to implement EETypePtrOf, but the IL-based implementation had problems with generic inlining so we replaced it in dotnet/corert#3814. The fallback IL was probably still used for CppCodegen at that time so it wasn't deleted.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
|
Cc @yowl - you might be able to delete similar handling on the WASM side. If I see right, WASM doesn't consider EETypePtrOf an intrinsic yet so it falls back to the IL I'm deleting - the handling of EETypePtrOf should be same as DefaultConstructorOf except instead of getting the default constructor, we get the |
This was referenced Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetValueInternal may or may not go away from RyuJIT at some point.
We originally used this to implement EETypePtrOf, but the IL-based implementation had problems with generic inlining so we replaced it in dotnet/corert#3814.
The fallback IL was probably still used for CppCodegen at that time so it wasn't deleted.