Annotate System.Private.Reflection.Core

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/Assemblies/RuntimeAssembly.cs

@@ -6,6 +6,7 @@
 using System.IO;
 using System.Text;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using System.Runtime.Serialization;
 using System.Reflection.Runtime.General;
@@ -121,6 +122,7 @@ public sealed override AssemblyName GetName()
             return RuntimeAssemblyName.ToAssemblyName();
         }
 
+        [RequiresUnreferencedCode("Types might be removed")]
         public sealed override Type[] GetForwardedTypes()
         {
             List<Type> types = new List<Type>();
@@ -175,6 +177,7 @@ public sealed override Type[] GetForwardedTypes()
         /// </summary>
         protected abstract IEnumerable<TypeForwardInfo> TypeForwardInfos { get; }
 
+        [RequiresUnreferencedCode("Types might be removed")]
         private static void AddPublicNestedTypes(Type type, List<Type> types)
         {
             foreach (Type nestedType in type.GetNestedTypes(BindingFlags.Public))

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/General/Helpers.cs

@@ -4,6 +4,7 @@
 using System.Text;
 using System.Reflection;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
@@ -152,6 +153,8 @@ public static bool NeedsEscapingInTypeName(this char c)
 
         private static readonly char[] s_charsToEscape = new char[] { '\\', '[', ']', '+', '*', '&', ',' };
 
+        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2070:UnrecognizedReflectionPattern",
+            Justification = "Delegates always generate metadata for the Invoke method")]
         public static RuntimeMethodInfo GetInvokeMethod(this RuntimeTypeInfo delegateType)
         {
             Debug.Assert(delegateType.IsDelegate);

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/MethodInfos/CustomMethodMapper.Nullable.cs

@@ -4,6 +4,7 @@
 using System.Collections.Generic;
 using System.Runtime.CompilerServices;
 using System.Reflection.Runtime.General;
+using System.Diagnostics.CodeAnalysis;
 
 namespace System.Reflection.Runtime.MethodInfos
 {
@@ -74,15 +75,17 @@ public static Dictionary<MethodBase, CustomMethodInvokerAction> Map
                             }
                         );
 
-                        map.AddMethod(type, nameof(Nullable<int>.GetValueOrDefault), Array.Empty<Type>(),
-                            (object thisObject, object[] args, Type thisType) =>
-                            {
-                                if (thisObject == null)
-                                    return RuntimeHelpers.GetUninitializedObject(thisType.GenericTypeArguments[0]);
+                        map.AddMethod(type, nameof(Nullable<int>.GetValueOrDefault), Array.Empty<Type>(), NullableGetValueOrDefault);
 
-                                return thisObject;
-                            }
-                        );
+                        static object NullableGetValueOrDefault(object thisObject, object[] args,
+                            [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors | DynamicallyAccessedMemberTypes.NonPublicConstructors)]
+                            Type thisType)
+                        {
+                            if (thisObject == null)
+                                return RuntimeHelpers.GetUninitializedObject(thisType);
+
+                            return thisObject;
+                        }
 
                         map.AddMethod(type, nameof(Nullable<int>.GetValueOrDefault), new Type[] { theT },
                             (object thisObject, object[] args, Type thisType) =>

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/MethodInfos/CustomMethodMapper.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 
 using Internal.Reflection.Core.Execution;
@@ -45,6 +46,8 @@ private static void AddConstructor(this Dictionary<MethodBase, CustomMethodInvok
             map.AddMethod(declaringType, ConstructorInfo.ConstructorName, parameterTypes, action);
         }
 
+        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2070:UnrecognizedReflectionPattern",
+            Justification = "GetConstructor/GetMethod being null is handled and expected.")]
         private static void AddMethod(this Dictionary<MethodBase, CustomMethodInvokerAction> map, Type declaringType, string name, Type[] parameterTypes, CustomMethodInvokerAction action)
         {
             const BindingFlags bf = BindingFlags.Public | BindingFlags.Instance | BindingFlags.Static | BindingFlags.DeclaredOnly | BindingFlags.ExactBinding;

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/TypeInfos/RuntimeTypeInfo.InvokeMember.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Collections.Generic;
 using System.Reflection.Runtime.BindingFlagSupport;
@@ -10,6 +11,7 @@ namespace System.Reflection.Runtime.TypeInfos
 {
     internal abstract partial class RuntimeTypeInfo
     {
+        [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)]
         public sealed override object InvokeMember(
             string name, BindingFlags bindingFlags, Binder binder, object target,
             object[] providedArgs, ParameterModifier[] modifiers, CultureInfo culture, string[] namedParams)

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/TypeInfos/RuntimeTypeInfo.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Collections.Generic;
 using System.Runtime.CompilerServices;
 using System.Reflection.Runtime.General;
@@ -185,6 +186,13 @@ public sealed override Type[] GenericTypeArguments
             }
         }
 
+        [DynamicallyAccessedMembers(
+                DynamicallyAccessedMemberTypes.PublicFields
+                | DynamicallyAccessedMemberTypes.PublicMethods
+                | DynamicallyAccessedMemberTypes.PublicEvents
+                | DynamicallyAccessedMemberTypes.PublicProperties
+                | DynamicallyAccessedMemberTypes.PublicConstructors
+                | DynamicallyAccessedMemberTypes.PublicNestedTypes)]
         public sealed override MemberInfo[] GetDefaultMembers()
         {
             string defaultMemberName = GetDefaultMemberName();

src/coreclr/nativeaot/System.Private.Reflection.Core/src/System/Reflection/Runtime/TypeParsing/TypeName.cs

@@ -114,7 +114,7 @@ public sealed override string ToString()
             return _declaringType + "+" + _nestedTypeName.EscapeTypeNameIdentifier();
         }
 
-        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2070:UnrecognizedReflectionPattern",
+        [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2075:UnrecognizedReflectionPattern",
             Justification = "Reflection implementation")]
         public sealed override Type ResolveType(Assembly containingAssemblyIfAny, GetTypeOptions getTypeOptions)
         {