[NativeAOT-LLVM] A couple of missing symbol fixes #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
commented
Jan 10, 2024
| @@ -190,7 +190,7 @@ | |||
| <Compile Include="System\Diagnostics\StackTrace.NativeAot.Browser.cs" Condition="'$(TargetOS)' == 'browser'" /> | |||
| <Compile Include="System\Diagnostics\StackTrace.NativeAot.Wasi.cs" Condition="'$(TargetOS)' == 'wasi'" /> | |||
| <Compile Include="System\Diagnostics\Eventing\EventPipe.NativeAot.cs" /> | |||
| <Compile Include="System\Diagnostics\Eventing\NativeRuntimeEventSource.Threading.NativeSinks.NativeAot.cs" /> | |||
| <Compile Include="System\Diagnostics\Eventing\NativeRuntimeEventSource.Threading.NativeSinks.NativeAot.cs" Condition="'$(FeaturePerfTracing)' == 'true'" /> | |||
SingleAccretion
commented
Jan 10, 2024
Comment on lines
-207
to
+208
| // The Unix version of this function allocates memory with 64K alignment, even as nothing needs such large | ||
| // alignments as of the writing of this comment. We do have to return something at least page-aligned. | ||
| const unsigned Alignment = 64 * 1024; | ||
| ASSERT(OS_PAGE_SIZE <= Alignment); | ||
|
|
||
| void* pRetVal; | ||
| if (posix_memalign(&pRetVal, Alignment, size) != 0) | ||
| if (posix_memalign(&pRetVal, OS_PAGE_SIZE, size) != 0) |
There was a problem hiding this comment.
This alignment compatibility quirk was removed upstream.
|
@dotnet/nativeaot-llvm |
SingleAccretion
force-pushed
the
Missing-Symbol-Fixes
branch
from
488cde3 to
8182446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly EventSource-related fixes.
Contributes to #2454.