Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability checks across DllImportGenerator #213

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Enable nullability checks across DllImportGenerator #213

merged 3 commits into from
Oct 20, 2020

Conversation

jkoritzinsky
Copy link
Member

Enable nullable everywhere in the project instead of our current patchwork enable/disable system.

Fixes #134

@jkoritzinsky jkoritzinsky added the area-DllImportGenerator Source Generated stubs for P/Invokes in C# label Oct 12, 2020
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am less than convinced any of this "nullability" logic is worth the effort. It is simply noise and increases metadata for no obvious win.

DllImportGenerator/DllImportGenerator/DllImportGenerator.cs Show resolved Hide resolved
@jkoritzinsky jkoritzinsky merged commit 7b2591d into dotnet:DllImportGenerator Oct 20, 2020
@jkoritzinsky jkoritzinsky deleted the nullability branch October 20, 2020 18:19
jkoritzinsky added a commit to jkoritzinsky/runtime that referenced this pull request Sep 20, 2021
@jkoritzinsky
Enable nullability checks across DllImportGenerator (dotnet/runtimela…
6bb8819 
…b#213)

Commit migrated from dotnet/runtimelab@7b2591d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

@elinor-fung elinor-fung Awaiting requested review from elinor-fung

Assignees
No one assigned
Labels
area-DllImportGenerator Source Generated stubs for P/Invokes in C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @AaronRobinsonMSFT