Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Double default initial heap size #99927

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

kg
Copy link
Contributor

@kg kg commented Mar 18, 2024

While we attempt to calculate a better initial heap size based on how big our DLLs are, the default minimum threshold is too low. In my testing with a very small app, the heap grows to around double this size just during the process of initializing sgen, and it does so in multiple steps instead of one big step. We may want to go even further than this, or look into a way of calculating the right value that takes things like sgen into account.

@kg kg added the arch-wasm WebAssembly architecture label Mar 18, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@kg kg merged commit 34dc259 into dotnet:main Mar 19, 2024
31 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants