Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #99901

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 18, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/installer

  • Subscription: 2a4e5111-6978-401f-68a5-08dba3b24dbe
  • Build:
  • Date Produced: March 25, 2024 1:08:49 PM UTC
  • Commit: dc43d363d284c26cb1b463683d6ebb2c88ab0b58
  • Branch: refs/heads/main

Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.3.24161.2 -> To Version 9.0.100-preview.3.24165.20
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Mar 18, 2024
Microsoft.Dotnet.Sdk.Internal
 From Version 9.0.100-preview.3.24161.2 -> To Version 9.0.100-preview.4.24175.5
@lewing lewing requested a review from maraf March 26, 2024 16:38
@lewing
Copy link
Member

lewing commented Mar 26, 2024

@maraf please take a look at the failures here

@maraf
Copy link
Member

maraf commented Mar 26, 2024

These look like webcil is not doing the thing

  • /root/helix/work/workitem/e/wbt artifacts/nuget/blz_razor_lib_top_szatthlc_5to/microsoft.net.sdk.webassembly.pack/9.0.0-ci/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets(572,5): error BLAZORSDK1001: Unable to find 'RazorClassLibrary.wasm' to be lazy loaded later. Confirm that project or package references are included and the reference is used in the project. [/root/helix/work/workitem/e/wbt artifacts/blz_razor_lib_top_szatthlc_5to/wasm/wasm.csproj]
  • /root/helix/work/workitem/e/wbt artifacts/nuget/AppSettingsTests_xbrleep4_3af/microsoft.net.sdk.webassembly.pack/9.0.0-ci/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets(572,5): error BLAZORSDK1001: Unable to find 'Json.wasm' to be lazy loaded later. Confirm that project or package references are included and the reference is used in the project. [/root/helix/work/workitem/e/wbt artifacts/AppSettingsTests_xbrleep4_3af/App/WasmBasicTestApp.csproj]
  • ...

Everything worked during build, but during publish all assemblies vanished
image

The problem is that ProcessPublishFilesForWasm gets hooked in for nested publish, which skips the target and thus ComputeWasmPublishAssets is not run. Why it doesn't run in the outer publish? Probably related to dotnet/sdk#39405

=> ResolveCompressedFilesForPublishDependsOn and CompressFilesForPublishDependsOn were causing boot config generation inside of a nested publish

This seems random

  • /root/helix/work/workitem/e/wbt artifacts/nuget/blazor_Debug_shvrqc3x_ylh/microsoft.net.sdk.webassembly.pack/9.0.0-ci/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets(572,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/root/helix/work/workitem/e/wbt artifacts/blazor_Debug_shvrqc3x_ylh/blazor_Debug_shvrqc3x_ylh.csproj]

@maraf maraf merged commit 71e989d into main Mar 28, 2024
158 of 160 checks passed
@maraf maraf deleted the darc-main-79718899-9281-4f46-81bb-d87a1007890d branch March 28, 2024 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants